You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/09/03 09:39:34 UTC

[PR] fix(desktop): reload Vite when workspace exports change [maka]

Astro-Han opened a new pull request, #4643:
URL: https://github.com/apache/maka/pull/4643

   ## Summary
   
   When a running Desktop dev server loads an updated renderer import after a workspace adds a package export, Vite can keep resolving against the old manifest and show `"./workhub-session-resolver" is not exported under the conditions [...]`. The export introduced in #4439 is present in main; the stale resolver is the failing boundary.
   
   Register the root manifest and its declared workspace manifests as Vite configuration dependencies. Vite then watches these files outside the renderer root and uses its existing server restart path to replace the native resolver cache. Ordinary file watching alone does not clear that cache.
   
   The addition is a dev-only Vite plugin for missing invalidation metadata. Package exports remain the resolution authority; there is no separate cache or restart controller to maintain. Workspace build outputs still come from the existing build flow. This does not add library, main-process, or preload hot rebuilding.
   
   ## Verification
   
   - Regression obligation: after a workspace adds an export and an existing renderer module imports it, the same dev-server URL serves the updated module successfully. One real Vite HTTP test covers this with the workspace output already built, and is included in Desktop `test:dist`.
   - Confirmed RED with the exact screenshot error and HTTP 500; GREEN after the change. Removing workspace manifest registration reproduces the failure again.
   - 21 targeted tests passed: the new regression and existing dev launcher tests, after building `@maka/core`.
   - Actual Desktop Vite configuration served `application/contracts/workhub-request-intent.ts` with HTTP 200 and resolved the new core export.
   - `npm run format`, `npm run lint`, focused plugin TypeScript check, Windows test inventory, and `git diff --check` passed.
   - Full workspace suites and an Electron window were not run; this changes development module resolution, with no visual layout change.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex investigated the resolver cache, implemented the Vite integration, and wrote and ran the regression test.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(desktop): reload Vite when workspace exports change [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4643:
URL: https://github.com/apache/maka/pull/4643


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org