You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/07/24 18:23:10 UTC
Review Request 36750: GEODE-153: fix race in testRemoteCacheListener
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36750/
-----------------------------------------------------------
Review request for geode and Kirk Lund.
Repository: geode
Description
-------
Both testRemoteCacheListener and testRemoteCacheListenerInSubregion used sleeps
to try to avoid no-ack races. Both tests now use a wait criteria.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java dfbc82d7939a923d989233077b66f4de4e23c67f
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/TestCacheCallback.java a252059a813d937e53c8cdfcecee724ff48d7f07
Diff: https://reviews.apache.org/r/36750/diff/
Testing
-------
MultiVMRegionTestCase tests
Thanks,
Darrel Schneider
Re: Review Request 36750: GEODE-153: fix race in
testRemoteCacheListener
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36750/#review92956
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On July 24, 2015, 4:23 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36750/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 4:23 p.m.)
>
>
> Review request for geode and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Both testRemoteCacheListener and testRemoteCacheListenerInSubregion used sleeps
> to try to avoid no-ack races. Both tests now use a wait criteria.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java dfbc82d7939a923d989233077b66f4de4e23c67f
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/TestCacheCallback.java a252059a813d937e53c8cdfcecee724ff48d7f07
>
> Diff: https://reviews.apache.org/r/36750/diff/
>
>
> Testing
> -------
>
> MultiVMRegionTestCase tests
>
>
> Thanks,
>
> Darrel Schneider
>
>