You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/13 11:28:37 UTC

[GitHub] [ozone] sodonnel commented on pull request #2377: HDDS-5296. Replication Manager should not sent replica command to DN which is not in IN_SERVICE opState

sodonnel commented on pull request #2377:
URL: https://github.com/apache/ozone/pull/2377#issuecomment-879007921


   Thanks for addressing the review comments @ChenSammi. I think this change looks better now. I just have one more comment inline where you are getting the nodeStatus - I think you should call the existing NodeManager API to get it so it is all protected under a lock.
   
   >  Removing the dead dn from topology seems a good idea.
   
   I think we should do that part under a separate Jira as its a slightly different change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org