[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #490: nimble: Add initial support for Core Spec 5.1

[GitBox <gi...@apache.org>]

sjanc commented on a change in pull request #490: nimble: Add initial support for Core Spec 5.1
URL: https://github.com/apache/mynewt-nimble/pull/490#discussion_r294498906
 
 

 ##########
 File path: nimble/include/nimble/hci_common.h
 ##########
 @@ -596,6 +614,54 @@ extern "C" {
 #define BLE_HCI_PRIVACY_NETWORK                     (0)
 #define BLE_HCI_PRIVACY_DEVICE                      (1)
 
+/* --- LE Receiver Test command [v3] (OCF 0x004F)*/
+#define BLE_HCI_LE_RX_TEST_V3_LEN                   BLE_HCI_VARIABLE_LEN
+
+/* --- LE Transmitter Test command [v3] (OCF 0x0050)*/
+#define BLE_HCI_LE_TX_TEST_V3_LEN                   BLE_HCI_VARIABLE_LEN
+
+/* ---   LE Set Connectionless CTE Transmit Parameters (OCF 0x0051) */
+#define BLE_HCI_LE_SET_CONNLESS_CTE_TX_PARAMS_LEN BLE_HCI_VARIABLE_LEN
+
+/* --- LE Set Connectionless CTE Transmit Enable (OCF 0x0052) */
+#define BLE_HCI_LE_SET_CONNLESS_CTE_TX_ENABLE_LEN   (2)
+
+/* --- LE Set Connectionless IQ Sampling Enable (OCF 0x0053) */
+#define BLE_HCI_LE_SET_CONNLESS_IQ_SAMPLING_ENABLE_LEN  BLE_HCI_VARIABLE_LEN
+
+/* --- LE Set Connection CTE Receive Parameters (OCF 0x0054) */
+#define BLE_HCI_LE_SET_CONN_CTE_RX_PARAMS_LEN
+
+/* --- LE Set Connection CTE Transmit Parameters (OCF 0x0055) */
+#define BLE_HCI_LE_SET_CONN_CTE_TX_PARAMS_LEN       BLE_HCI_VARIABLE_LEN
+
+/* --- LE Connection CTE Request Enable (OCF 0x0056) */
+#define BLE_HCI_LE_SET_CONN_CTE_REQ_ENABLE_LEN      (7)
+
+/* --- LE Connection CTE Response Enable (OCF 0x0057) */
+#define BLE_HCI_LE_SET_CONN_CTE_RESP_ENABLE_LEN     (3)
+
+/* --- LE Set Periodic Advertising Receive Enable (OCF 0x0059) */
+#define BLE_HCI_LE_PERIODIC_ADV_RECEIVE_ENABLE_LEN  (3)
+
+/* --- LE Periodic Advertising Sync Transfer (OCF 0x005A) */
+#define BLE_HCI_LE_PERIODIC_ADV_SYNC_TRANSFER_LEN   (6)
+
+/* --- LE Periodic Advertising Set Info Transfer (OCF 0x005B) */
+#define BLE_HCI_LE_PERIODIC_ADV_SET_INFO_TRANSFER_LEN   (5)
+
+/* --- LE Set Periodic Advertising Sync Transfer Parameters (OCF 0x005C) */
+#define BLE_HCI_LE_PERIODIC_ADV_SYNC_TRANSFER_PARAMS_LEN    (9)
 
 Review comment:
   good catch, thanks
   
   although I've started working on reworking code we have for parsing hci commands/events which will make those defines obsolete,  I'll rebase this patch on top of that work when it is done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services