You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/25 13:23:05 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #13163: [FLINK-16789][runtime] Support JMX RMI random port assign

tillrohrmann commented on a change in pull request #13163:
URL: https://github.com/apache/flink/pull/13163#discussion_r476443994



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/management/JMXService.java
##########
@@ -85,6 +86,9 @@ private static JMXServer startJMXServerWithPortRanges(Iterator<Integer> ports) {
 		while (ports.hasNext() && successfullyStartedServer == null) {
 			JMXServer server = new JMXServer();
 			int port = ports.next();
+			if (port == 0) { // try poke with a random port when port is set to zero

Review comment:
       I would be hesitant in introducing this kind of magic with `0` mapping to `10000 - 65000`. Isn't it good enough to simply specify an explicit range if one runs multiple JMX services on the same node?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org