You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2020/09/17 17:25:53 UTC

[kudu-CR] [master] KUDU-2181 Raft ChangeConfig request to add a master

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16321

to look at the new patch set (#5).

Change subject: [master] KUDU-2181 Raft ChangeConfig request to add a master
......................................................................

[master] KUDU-2181 Raft ChangeConfig request to add a master

This change:
- Adds hidden feature flag "--master_support_change_config" off by
  default.
- RPC changes to add a master that initiates Raft config change and
  responds asynchronously.
- RPC changes to report back member type(VOTER/NON_VOTER) of masters
- Removes the cached master_addresses in catalog manager as it's no
  longer static.
- Updates and adds comments in MasterOptions such that it's used to
  fetch master addresses only during master init time as masters can
  be added/removed dynamically with this change.
- Updates ListMasters() to look at local Raft config instead of
  MasterOptions as the masters can be added/removed dynamically.

If the new master can be caught up from the WAL then the master
gets promoted to VOTER else it remains as NON_VOTER without master
tablet copying support.

Change-Id: I0ac7e6e55220bcb01cad0fa386daaf656258088c
---
M src/kudu/common/wire_protocol.proto
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/master/CMakeLists.txt
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
A src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master.cc
M src/kudu/master/master.h
M src/kudu/master/master.proto
M src/kudu/master/master_options.cc
M src/kudu/master/master_options.h
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_service.cc
M src/kudu/master/master_service.h
M src/kudu/master/mini_master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/mini-cluster/external_mini_cluster.h
M src/kudu/tools/tool_action_master.cc
20 files changed, 869 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/16321/5
-- 
To view, visit http://gerrit.cloudera.org:8080/16321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ac7e6e55220bcb01cad0fa386daaf656258088c
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 5
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)