You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/22 23:42:57 UTC
[GitHub] [spark] gatorsmile commented on a change in pull request #24859:
[SPARK-28033][SQL] String concatenation should low priority than other
operators
gatorsmile commented on a change in pull request #24859: [SPARK-28033][SQL] String concatenation should low priority than other operators
URL: https://github.com/apache/spark/pull/24859#discussion_r296460422
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -668,10 +668,11 @@ valueExpression
: primaryExpression #valueExpressionDefault
Review comment:
Could you add a comment above line 667?
> Note: check the operator precedence when adding the new operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org