You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/25 14:12:53 UTC
[GitHub] [pulsar] tisonkun opened a new issue, #16783: check-binary-license.sh doesn't check Pulsar SQL licenses in CI
tisonkun opened a new issue, #16783:
URL: https://github.com/apache/pulsar/issues/16783
https://github.com/apache/pulsar/blob/52d8fe03160648f14dc196edaa87921064a1b2b2/.github/workflows/pulsar-ci.yaml#L106-L113
When build and check license in CI, we don't build with Pulsar SQL module. Thus, we can miss dependencies bump to Pulsar SQL, as in https://github.com/apache/pulsar/pull/16508#issuecomment-1194035662 and the first attempt of https://github.com/apache/pulsar/pull/16683.
I don't know whether it's required to build with `-Pcore-modules,-main`, but if we want to check binary licenses correctly, current workflow doesn't achieve the goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #16783: check-binary-license.sh doesn't check Pulsar SQL licenses in CI
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #16783:
URL: https://github.com/apache/pulsar/issues/16783#issuecomment-1247636919
> @lhotari thoughts? I'm not sure where we can run the check-binary-license.sh with a Pulsar SQL distro.
@tisonkun Please take a look at #15253 . The license check should be done when the docker image is built.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #16783: check-binary-license.sh doesn't check Pulsar SQL licenses in CI
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #16783:
URL: https://github.com/apache/pulsar/issues/16783#issuecomment-1226693623
@lhotari thoughts? I'm not sure where we can run the check-binary-license.sh with a Pulsar SQL distro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #16783: check-binary-license.sh doesn't check Pulsar SQL licenses in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #16783:
URL: https://github.com/apache/pulsar/issues/16783#issuecomment-1226691442
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #16783: check-binary-license.sh doesn't check Pulsar SQL licenses in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #16783:
URL: https://github.com/apache/pulsar/issues/16783#issuecomment-1279873922
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed issue #16783: check-binary-license.sh doesn't check Pulsar SQL licenses in CI
Posted by GitBox <gi...@apache.org>.
Technoboy- closed issue #16783: check-binary-license.sh doesn't check Pulsar SQL licenses in CI
URL: https://github.com/apache/pulsar/issues/16783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org