You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2002/05/31 22:50:14 UTC

cvs commit: httpd-2.0/modules/generators mod_autoindex.c

trawick     2002/05/31 13:50:14

  Modified:    modules/generators mod_autoindex.c
  Log:
  if we autoindex, discard the request body and check for any
  errors doing so
  
  Revision  Changes    Path
  1.109     +6 -0      httpd-2.0/modules/generators/mod_autoindex.c
  
  Index: mod_autoindex.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/generators/mod_autoindex.c,v
  retrieving revision 1.108
  retrieving revision 1.109
  diff -u -r1.108 -r1.109
  --- mod_autoindex.c	18 May 2002 04:13:12 -0000	1.108
  +++ mod_autoindex.c	31 May 2002 20:50:14 -0000	1.109
  @@ -2133,6 +2133,12 @@
       /* OK, nothing easy.  Trot out the heavy artillery... */
   
       if (allow_opts & OPT_INDEXES) {
  +        int errstatus;
  +
  +        if ((errstatus = ap_discard_request_body(r)) != OK) {
  +            return errstatus;
  +        }
  +
           /* KLUDGE --- make the sub_req lookups happen in the right directory.
            * Fixing this in the sub_req_lookup functions themselves is difficult,
            * and would probably break virtual includes...
  
  
  

Re: cvs commit: httpd-2.0/modules/generators mod_autoindex.c

Posted by Jeff Trawick <tr...@attglobal.net>.
Greg Stein <gs...@lyra.org> writes:

> On Fri, May 31, 2002 at 08:50:14PM -0000, trawick@apache.org wrote:
> > trawick     2002/05/31 13:50:14
> > 
> >   Modified:    modules/generators mod_autoindex.c
> >   Log:
> >   if we autoindex, discard the request body and check for any
> >   errors doing so
> 
> When a request finishes, it will toss the request body. Why does autoindex
> need to do this manually?

It isn't happening (or at least it wasn't happening Friday :) ).  Do
you have a hint about where the code to do that is?  Also, why does
default_handler() discard the request body if it is going to happen
automatically?

-- 
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...

Re: cvs commit: httpd-2.0/modules/generators mod_autoindex.c

Posted by Greg Stein <gs...@lyra.org>.
On Fri, May 31, 2002 at 08:50:14PM -0000, trawick@apache.org wrote:
> trawick     2002/05/31 13:50:14
> 
>   Modified:    modules/generators mod_autoindex.c
>   Log:
>   if we autoindex, discard the request body and check for any
>   errors doing so

When a request finishes, it will toss the request body. Why does autoindex
need to do this manually?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/