You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/11 07:59:27 UTC
[GitHub] [hadoop-ozone] maobaolong opened a new pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
maobaolong opened a new pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057
## What changes were proposed in this pull request?
Now, i think the yaml files under examples folder are trial purpose, so we should not add the strict limitation to prevent people easy to taste the example, if who want reference this example and use it in production env, then they will do a lot of modification.
For this ticket, it suppose to remove the podAntiAffinity check to let on node kubernetes run the ozone cluster on kubernetes successfully.
## What is the link to the Apache JIRA
https://jira.apache.org/jira/browse/HDDS-3782
## How was this patch tested?
No need, just loosing restrictions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-643159402
@elek I agree with your suggestion,
> I am sure that the real ozone example should have real podAntiAffinity as it provides an example to use real Ozone
Thank you to let me know well about the "ozone" and "ozone-dev" mean, now i agree to keep the podAntiAffinity for ozone dir
> minikube shouldn't have the podAntiAffinity
If fact, i don't know minikube at all, keep it.
> We can discuss getting-started and ozone-dev, I am open the adjust them.
I strongly recommend to remove podAntiAffinity and let it easy to start successfully.
> But it seems to unclear what is the goal of different subdirectories. Would be great to do it with additional clarification: either we need to add more README to clarify the goals, or create different structure (or dir names?)
Yeah, I have created a ticket to track this work, https://issues.apache.org/jira/browse/HDDS-3790
maybe someone who are very familiar with these directories can write a better README
So, for this PR, i suppose to let ozone CSI run successfully and easily, so i will revert the unrelated and un unnecessary file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-642533206
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/f7e95d9b015e764ca93cfe2ccfc96d95160931bc&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
- Coverage 69.48% 69.46% -0.03%
Complexity 9110 9110
============================================
Files 961 961
Lines 48132 48148 +16
Branches 4672 4679 +7
============================================
- Hits 33446 33445 -1
- Misses 12468 12481 +13
- Partials 2218 2222 +4
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/hadoop/hdds/scm/pipeline/Pipeline.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vcGlwZWxpbmUvUGlwZWxpbmUuamF2YQ==) | `85.23% <100.00%> (-0.27%)` | `44.00 <0.00> (+1.00)` | :arrow_down: |
| [.../org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT21LZXlJbmZvLmphdmE=) | `86.25% <100.00%> (+0.33%)` | `42.00 <0.00> (+2.00)` | |
| [...adoop/ozone/om/helpers/OmKeyLocationInfoGroup.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT21LZXlMb2NhdGlvbkluZm9Hcm91cC5qYXZh) | `75.60% <100.00%> (+1.25%)` | `12.00 <2.00> (+1.00)` | |
| [...g/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT3pvbmVBY2xVdGlsLmphdmE=) | `81.91% <100.00%> (+1.23%)` | `39.00 <4.00> (+2.00)` | |
| [...adoop/ozone/om/request/key/OMKeyCommitRequest.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yZXF1ZXN0L2tleS9PTUtleUNvbW1pdFJlcXVlc3QuamF2YQ==) | `97.00% <100.00%> (ø)` | `18.00 <0.00> (+1.00)` | |
| [...otocol/commands/RetriableDatanodeEventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL3Byb3RvY29sL2NvbW1hbmRzL1JldHJpYWJsZURhdGFub2RlRXZlbnRXYXRjaGVyLmphdmE=) | `55.55% <0.00%> (-44.45%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ache/hadoop/ozone/om/codec/S3SecretValueCodec.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9jb2RlYy9TM1NlY3JldFZhbHVlQ29kZWMuamF2YQ==) | `90.90% <0.00%> (-9.10%)` | `3.00% <0.00%> (-1.00%)` | |
| [...apache/hadoop/hdds/scm/block/BlockManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2Jsb2NrL0Jsb2NrTWFuYWdlckltcGwuamF2YQ==) | `66.66% <0.00%> (-5.41%)` | `18.00% <0.00%> (ø%)` | |
| [...e/commandhandler/CreatePipelineCommandHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9jb21tYW5kaGFuZGxlci9DcmVhdGVQaXBlbGluZUNvbW1hbmRIYW5kbGVyLmphdmE=) | `87.23% <0.00%> (-4.26%)` | `8.00% <0.00%> (ø%)` | |
| [...apache/hadoop/hdds/server/events/EventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zZXJ2ZXIvZXZlbnRzL0V2ZW50V2F0Y2hlci5qYXZh) | `77.77% <0.00%> (-4.17%)` | `14.00% <0.00%> (ø%)` | |
| ... and [16 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=footer). Last update [53395a0...77253c3](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-650340259
@elek Thank you for your help, i catch you point is let me modify the source file of the Flekszible. I think I've done following your instruments. PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter edited a comment on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-642533206
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/f7e95d9b015e764ca93cfe2ccfc96d95160931bc&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
- Coverage 69.48% 69.38% -0.11%
+ Complexity 9110 9107 -3
============================================
Files 961 961
Lines 48132 48127 -5
Branches 4672 4676 +4
============================================
- Hits 33446 33394 -52
- Misses 12468 12519 +51
+ Partials 2218 2214 -4
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/hadoop/hdds/scm/pipeline/Pipeline.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vcGlwZWxpbmUvUGlwZWxpbmUuamF2YQ==) | `85.71% <100.00%> (+0.20%)` | `44.00 <0.00> (+1.00)` | |
| [.../org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT21LZXlJbmZvLmphdmE=) | `86.25% <100.00%> (+0.33%)` | `42.00 <0.00> (+2.00)` | |
| [...adoop/ozone/om/helpers/OmKeyLocationInfoGroup.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT21LZXlMb2NhdGlvbkluZm9Hcm91cC5qYXZh) | `75.60% <100.00%> (+1.25%)` | `12.00 <2.00> (+1.00)` | |
| [...g/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hlbHBlcnMvT3pvbmVBY2xVdGlsLmphdmE=) | `81.91% <100.00%> (+1.23%)` | `39.00 <4.00> (+2.00)` | |
| [...adoop/ozone/om/request/key/OMKeyCommitRequest.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yZXF1ZXN0L2tleS9PTUtleUNvbW1pdFJlcXVlc3QuamF2YQ==) | `97.00% <100.00%> (ø)` | `18.00 <0.00> (+1.00)` | |
| [...otocol/commands/RetriableDatanodeEventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL3Byb3RvY29sL2NvbW1hbmRzL1JldHJpYWJsZURhdGFub2RlRXZlbnRXYXRjaGVyLmphdmE=) | `55.55% <0.00%> (-44.45%)` | `3.00% <0.00%> (-1.00%)` | |
| [...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy91dGlscy9Pem9uZU1hbmFnZXJSYXRpc1V0aWxzLmphdmE=) | `67.44% <0.00%> (-19.13%)` | `39.00% <0.00%> (ø%)` | |
| [.../apache/hadoop/hdds/scm/node/StaleNodeHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL25vZGUvU3RhbGVOb2RlSGFuZGxlci5qYXZh) | `88.88% <0.00%> (-11.12%)` | `4.00% <0.00%> (ø%)` | |
| [...che/hadoop/ozone/om/ratis/OMRatisSnapshotInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9PTVJhdGlzU25hcHNob3RJbmZvLmphdmE=) | `83.33% <0.00%> (-10.67%)` | `7.00% <0.00%> (-5.00%)` | |
| [...ache/hadoop/ozone/om/codec/S3SecretValueCodec.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9jb2RlYy9TM1NlY3JldFZhbHVlQ29kZWMuamF2YQ==) | `90.90% <0.00%> (-9.10%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [30 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=footer). Last update [53395a0...1bcec8a](https://codecov.io/gh/apache/hadoop-ozone/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-648818776
Update: when you import the file, the name of the statefulset should be updated in the trigger lines (datanode instead of ozone-datanode AFAIR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-650144219
I got it, and I convinced by you to remove the affinity rules from `ozone-dev` and `getting-started` and we agreed to keep it in `ozone` (as it supposed to be a production-like example).
My problem is that the files under `example` are **generated** to simplify the management. For example, we can add any new labels to the master template and regenerate all the examples.(with #1123).
I am convinced to remove the affinity rules *by default*, but if you do it **only** in the generated files, they will be overridden with the next generation. (To make all the files independent of the generation, I prefer to commit the end results, what you can see in the examples which makes the existence of the generation tool optional).
I tried to propose to modify BOTH the generated files AND the rules for the generation, to persist the change. It was not about following a different default.
(Sorry if it was not clear or misunderstood your comment)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-649150070
@elek Thank you for telling me how to change the example by `Flekszible`, but, in fact, i still want to start 3 datanode by default, and remove the affinity limitation, so that I can start 3 datanodes on an only one node kubernetes cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-643127553
Thanks to open this issue @maobaolong
This approach is already considered, and you can find the arguments in https://issues.apache.org/jira/browse/HDDS-1646 why do we have these persistence lines.
> Now, i think the yaml files under examples folder are trial purpose
Depends on how do you define *trial* purpose. I think the provided examples should work in a real, production-like environment. For example if somebody tries Ozone out in a small Kubernetes cluster, we should provide an example how can it be configured.
Removing the `podAntiAffinity` rules would result fake results of the initial measurements.
I understand that we have an other use case: To quickly try it out locally on Minikube, K3s or one node cluster. And I agree that we should support it. Today we have the `minikube` definitions for that specific use case.
* I am sure that the real `ozone` example should have real `podAntiAffinity` as it provides an example to use real Ozone
* `minikube` shouldn't have the `podAntiAffinity`
* We can discuss `getting-started` and `ozone-dev`, I am open the adjust them.
* But it seems to unclear what is the goal of different subdirectories. Would be great to do it with additional clarification: either we need to add more README to clarify the goals, or create different structure (or dir names?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-648801357
Thanks the update @maobaolong
My problem is that the examples are generated (see #1123). If you modify only the generated files, the changes will disappear.
If you propose to modify `ozone-dev` to run it on one single node by default, you should do the following:
1. copy [this file](https://github.com/flokkr/docker-ozone/blob/master/flekszible/ozone/definitions/onenode.yaml) to `hadoop-ozone/dist/src/main/k8s/definitions/ozone/definitions`
2. Add `ozone/onenode` transformations to the `Flekszible` file under `ozone-dev` and `getting-started`.
For example:
```
diff --git hadoop-ozone/dist/src/main/k8s/examples/ozone-dev/Flekszible hadoop-ozone/dist/src/main/k8s/examples/ozone-dev/Flekszible
index 96e8c6254..350ea73c5 100644
--- hadoop-ozone/dist/src/main/k8s/examples/ozone-dev/Flekszible
+++ hadoop-ozone/dist/src/main/k8s/examples/ozone-dev/Flekszible
@@ -26,6 +26,7 @@ import:
- type: ozone/profiler
- type: ozone/emptydir
- type: ozone/csi
+ - type: ozone/onenode
- path: prometheus
- path: jaeger
transformations:
```
3. Run `regenerate-all.sh` from `#1123` (You might need to install [flekszible](https://github.com/elek/flekszible) which can be done with brew or putting the single binary to the path)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1057: HDDS-3782. Remove podAntiAffinity from datanode-statefulset
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1057:
URL: https://github.com/apache/hadoop-ozone/pull/1057#issuecomment-650144950
With other words:
Try this: keep this commit, apply #1123, and run the new script. You will see that your changes are disappearing. I described the method to avoid this and save your changes ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org