You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2019/04/01 11:10:11 UTC
[tomcat] branch master updated:
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 924d15a https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
924d15a is described below
commit 924d15aa09c590f6d1b932a90df8297d333d2b2e
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Apr 1 12:08:42 2019 +0100
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
Document the differences in behaviour between the LogFormat directive in
httpd and the pattern attribute in the AccessLogValve for %D and %T.
---
webapps/docs/changelog.xml | 6 ++++++
webapps/docs/config/valve.xml | 9 +++++++--
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 80dda88..05c0aba 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -87,6 +87,12 @@
the new listener. (remm)
</update>
<fix>
+ <bug>63286</bug>: Document the differences in behaviour between the
+ <code>LogFormat</code> directive in httpd and the <code>pattern</code>
+ attribute in the <code>AccessLogValve</code> for <code>%D</code> and
+ <code>%T</code>. (markt)
+ </fix>
+ <fix>
<bug>63287</bug>: Make logging levels more consistent for similar issues
of similar severity. (markt)
</fix>
diff --git a/webapps/docs/config/valve.xml b/webapps/docs/config/valve.xml
index a96aa96..27125b1 100644
--- a/webapps/docs/config/valve.xml
+++ b/webapps/docs/config/valve.xml
@@ -304,8 +304,13 @@
<li><b>%u</b> - Remote user that was authenticated (if any), else '-'</li>
<li><b>%U</b> - Requested URL path</li>
<li><b>%v</b> - Local server name</li>
- <li><b>%D</b> - Time taken to process the request, in millis</li>
- <li><b>%T</b> - Time taken to process the request, in seconds</li>
+ <li><b>%D</b> - Time taken to process the request in millis. Note: In
+ httpd %D is microseconds. Behaviour will be aligned to httpd
+ in Tomcat 10 onwards.</li>
+ <li><b>%T</b> - Time taken to process the request, in seconds. Note: This
+ value has millisecond resolution whereas in httpd it has
+ second resolution. Behaviour will be align to httpd
+ in Tomcat 10 onwards.</li>
<li><b>%F</b> - Time taken to commit the response, in millis</li>
<li><b>%I</b> - Current request thread name (can compare later with stacktraces)</li>
<li><b>%X</b> - Connection status when response is completed:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch master updated:
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
Posted by Michael Osipov <mi...@apache.org>.
Am 2019-04-01 um 13:42 schrieb Mark Thomas:
> On 01/04/2019 12:41, Michael Osipov wrote:
>> Am 2019-04-01 um 13:10 schrieb markt@apache.org:
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> markt pushed a commit to branch master
>>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>>
>>>
>>> The following commit(s) were added to refs/heads/master by this push:
>>> new 924d15a
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
>>> 924d15a is described below
>>>
>>> commit 924d15aa09c590f6d1b932a90df8297d333d2b2e
>>> Author: Mark Thomas <ma...@apache.org>
>>> AuthorDate: Mon Apr 1 12:08:42 2019 +0100
>>>
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log
>>> formats
>>> Document the differences in behaviour between the LogFormat
>>> directive in
>>> httpd and the pattern attribute in the AccessLogValve for %D and %T.
>>> ---
>>> webapps/docs/changelog.xml | 6 ++++++
>>> webapps/docs/config/valve.xml | 9 +++++++--
>>> 2 files changed, 13 insertions(+), 2 deletions(-)
>>>
>>> + <li><b>%T</b> - Time taken to process the request, in seconds.
>>> Note: This
>>> + value has millisecond resolution whereas in httpd
>>> it has
>>> + second resolution. Behaviour will be align to httpd
>>> + in Tomcat 10 onwards.</li>
>>
>> One more nit, %T in Tomcat isn't just writing seconds, but seconds with
>> a fraction:
>
> Which is covered in the text above. The value is in seconds with
> millisecond resolution.
Ok, right, that's doesn't really popup unambiguously for the non-native
English reader.
Maybe precision and/or integer/double would really clarify.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch master updated:
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
Posted by Mark Thomas <ma...@apache.org>.
On 01/04/2019 12:41, Michael Osipov wrote:
> Am 2019-04-01 um 13:10 schrieb markt@apache.org:
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> markt pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>
>>
>> The following commit(s) were added to refs/heads/master by this push:
>> new 924d15a
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
>> 924d15a is described below
>>
>> commit 924d15aa09c590f6d1b932a90df8297d333d2b2e
>> Author: Mark Thomas <ma...@apache.org>
>> AuthorDate: Mon Apr 1 12:08:42 2019 +0100
>>
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log
>> formats
>> Document the differences in behaviour between the LogFormat
>> directive in
>> httpd and the pattern attribute in the AccessLogValve for %D and %T.
>> ---
>> webapps/docs/changelog.xml | 6 ++++++
>> webapps/docs/config/valve.xml | 9 +++++++--
>> 2 files changed, 13 insertions(+), 2 deletions(-)
>>
>> + <li><b>%T</b> - Time taken to process the request, in seconds.
>> Note: This
>> + value has millisecond resolution whereas in httpd
>> it has
>> + second resolution. Behaviour will be align to httpd
>> + in Tomcat 10 onwards.</li>
>
> One more nit, %T in Tomcat isn't just writing seconds, but seconds with
> a fraction:
Which is covered in the text above. The value is in seconds with
millisecond resolution.
Mark
>
>> } else {
>> // second
>> buf.append(Long.toString(time / 1000));
>> buf.append('.');
>> int remains = (int) (time % 1000);
>> buf.append(Long.toString(remains / 100));
>> remains = remains % 100;
>> buf.append(Long.toString(remains / 10));
>> buf.append(Long.toString(remains % 10));
>> }
>> }
>
> That's not really obvious, I guess.
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch master updated:
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
Posted by Michael Osipov <mi...@apache.org>.
Am 2019-04-01 um 13:10 schrieb markt@apache.org:
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 924d15a https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
> 924d15a is described below
>
> commit 924d15aa09c590f6d1b932a90df8297d333d2b2e
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Mon Apr 1 12:08:42 2019 +0100
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=63286 access log formats
>
> Document the differences in behaviour between the LogFormat directive in
> httpd and the pattern attribute in the AccessLogValve for %D and %T.
> ---
> webapps/docs/changelog.xml | 6 ++++++
> webapps/docs/config/valve.xml | 9 +++++++--
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> + <li><b>%T</b> - Time taken to process the request, in seconds. Note: This
> + value has millisecond resolution whereas in httpd it has
> + second resolution. Behaviour will be align to httpd
> + in Tomcat 10 onwards.</li>
One more nit, %T in Tomcat isn't just writing seconds, but seconds with
a fraction:
> } else {
> // second
> buf.append(Long.toString(time / 1000));
> buf.append('.');
> int remains = (int) (time % 1000);
> buf.append(Long.toString(remains / 100));
> remains = remains % 100;
> buf.append(Long.toString(remains / 10));
> buf.append(Long.toString(remains % 10));
> }
> }
That's not really obvious, I guess.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org