You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/12/05 17:18:41 UTC
[jira] [Commented] (FLUME-858) HDFSWriterFactory is using operation
== for string comparison
[ https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162862#comment-13162862 ]
jiraposter@reviews.apache.org commented on FLUME-858:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3010/
-----------------------------------------------------------
Review request for Flume and Eric Sammer.
Summary
-------
I've simply changed operator == to calling method equals().
This addresses bug FLUME-858.
https://issues.apache.org/jira/browse/FLUME-858
Diffs
-----
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriterFactory.java 1205921
Diff: https://reviews.apache.org/r/3010/diff
Testing
-------
No tests for this class are available yet (actually it would be great idea to create them :-D), however I did test it on my testing cluster.
Thanks,
Jarek
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira