[jira] [Commented] (HADOOP-12344) validateSocketPathSecurity0 message could be better

["Harsh J (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708952#comment-14708952 ] 

Harsh J commented on HADOOP-12344:
----------------------------------

This would be very useful to add to make it easier to understand what path the error's talking of. I know its pre-existed, but I wonder what's the use of asking people to select a different path (bound to have the same problem somehow).

Patch's changes look good, but I wonder if we should just drop that part of the message and instruct better on how to fix it?

A message such as:
{code}
java.io.IOException: the path component: '/' in '/var/run/hdfs-sockets/dn' is world-writable. Its permissions are 0077. Expected permission is XXX. Please fix this.
{code}
(or similar) … would be more actionable, no?

> validateSocketPathSecurity0 message could be better
> ---------------------------------------------------
>
>                 Key: HADOOP-12344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12344
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: net
>            Reporter: Casey Brotherton
>            Assignee: Casey Brotherton
>            Priority: Trivial
>         Attachments: HADOOP-12344.patch
>
>
> When a socket path does not have the correct permissions, an error is thrown.
> That error just has the failing component of the path and not the entire path of the socket.
> The entire path of the socket could be printed out to allow for a direct check of the permissions of the entire path.
> {code}
> java.io.IOException: the path component: '/' is world-writable.  Its permissions are 0077.  Please fix this or select a different socket path.
> 	at org.apache.hadoop.net.unix.DomainSocket.validateSocketPathSecurity0(Native Method)
> 	at org.apache.hadoop.net.unix.DomainSocket.bindAndListen(DomainSocket.java:189)
> ...
> {code}
> The error message could also provide the socket path:
> {code}
> java.io.IOException: the path component: '/' is world-writable.  Its permissions are 0077.  Please fix this or select a different socket path than '/var/run/hdfs-sockets/dn'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)