You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/27 12:26:38 UTC

[GitHub] [flink] rmetzger opened a new pull request #11241: [FLINK-16292] Add missing end to end tests

rmetzger opened a new pull request #11241: [FLINK-16292] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241
 
 
   ## What is the purpose of the change
   
   - On azure, we are using the `run-nightly-tests.sh` script to run the end to end tests. However, not all end to end tests are listed in that file. In this change, we add a first batch of missing end to end tests from the `tools/travis/splits` folder.
   - Currently, all PRs / master pushes are marked red, because of failing end to end tests. This change has green e2e tests, making the overall test green.
   
   
   ## Brief change log
   
    - As a follow up to https://github.com/apache/flink/pull/11222, this PR is unifying the mechanism for switch between jdk8 and jdk11.
   - The missing e2e tests from the splits folder were added
   - failing e2e tests were removed (for now: I will add them as I make them more stable again)
   
   
   ## Verifying this change
   
   The change has been tested here: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5684&view=results
   
   ## Does this pull request potentially affect one of the following parts:
   
   only build system files were touched
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385598077
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
 
 Review comment:
   I'm not sure though if the java end to end tests are properly executed, because 4 minutes seems very short.
   But I wanted to investigate that another ticket

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385589190
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -185,5 +198,32 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+set -x
+HERE="`dirname \"$0\"`"				# relative
 
 Review comment:
   are you talking about the vertical whitespace?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11241: [FLINK-16292] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11241: [FLINK-16292] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591945049
 
 
   Please add the appropriate component tags to the commit messages and PR title.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385611004
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
 
 Review comment:
   4 minutes should actually be fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385098255
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -185,5 +198,32 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+set -x
+HERE="`dirname \"$0\"`"				# relative
 
 Review comment:
   reduce whitespace

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385611973
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
 
 Review comment:
   Ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385588476
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
+if [ -z "${HERE}" ] ; then
+	# error; for some reason, the path is not accessible
+	# to the script (e.g. permissions re-evaled after suid)
+	exit 1  # fail
+fi
+ARTIFACTS_DIR="${HERE}/artifacts"
+mkdir -p $ARTIFACTS_DIR || { echo "FAILURE: cannot create log directory '${ARTIFACTS_DIR}'." ; exit 1; }
+
+LOG4J_PROPERTIES=${HERE}/../tools/log4j-travis.properties
+
+MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} -Dlog4j.configurationFile=file://$LOG4J_PROPERTIES -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
+MVN_COMMON_OPTIONS="-nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -Dmaven.wagon.http.pool=false -Dfast -Pskip-webui-build"
+e2e_modules=$(find flink-end-to-end-tests -mindepth 2 -maxdepth 5 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')
+e2e_modules="${e2e_modules},$(find flink-walkthroughs -mindepth 2 -maxdepth 2 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')"
+
+PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6"
+mvn ${MVN_COMMON_OPTIONS} ${MVN_LOGGING_OPTIONS} ${PROFILE} verify -pl ${e2e_modules} -DdistDir=$(readlink -e build-target)
 
 Review comment:
   If the build is green regardless there's likely a but in the error reporting.
   
   Where do you actually fail with an error if this command fails?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385592041
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
+if [ -z "${HERE}" ] ; then
+	# error; for some reason, the path is not accessible
+	# to the script (e.g. permissions re-evaled after suid)
+	exit 1  # fail
+fi
+ARTIFACTS_DIR="${HERE}/artifacts"
+mkdir -p $ARTIFACTS_DIR || { echo "FAILURE: cannot create log directory '${ARTIFACTS_DIR}'." ; exit 1; }
+
+LOG4J_PROPERTIES=${HERE}/../tools/log4j-travis.properties
+
+MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} -Dlog4j.configurationFile=file://$LOG4J_PROPERTIES -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
+MVN_COMMON_OPTIONS="-nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -Dmaven.wagon.http.pool=false -Dfast -Pskip-webui-build"
+e2e_modules=$(find flink-end-to-end-tests -mindepth 2 -maxdepth 5 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')
+e2e_modules="${e2e_modules},$(find flink-walkthroughs -mindepth 2 -maxdepth 2 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')"
+
+PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6"
+mvn ${MVN_COMMON_OPTIONS} ${MVN_LOGGING_OPTIONS} ${PROFILE} verify -pl ${e2e_modules} -DdistDir=$(readlink -e build-target)
 
 Review comment:
   > Where do you actually fail with an error if this command fails?
   
   I will fix this!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385588022
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
+if [ -z "${HERE}" ] ; then
+	# error; for some reason, the path is not accessible
+	# to the script (e.g. permissions re-evaled after suid)
+	exit 1  # fail
+fi
+ARTIFACTS_DIR="${HERE}/artifacts"
+mkdir -p $ARTIFACTS_DIR || { echo "FAILURE: cannot create log directory '${ARTIFACTS_DIR}'." ; exit 1; }
+
+LOG4J_PROPERTIES=${HERE}/../tools/log4j-travis.properties
+
+MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} -Dlog4j.configurationFile=file://$LOG4J_PROPERTIES -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
+MVN_COMMON_OPTIONS="-nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -Dmaven.wagon.http.pool=false -Dfast -Pskip-webui-build"
+e2e_modules=$(find flink-end-to-end-tests -mindepth 2 -maxdepth 5 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')
+e2e_modules="${e2e_modules},$(find flink-walkthroughs -mindepth 2 -maxdepth 2 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')"
+
+PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6"
+mvn ${MVN_COMMON_OPTIONS} ${MVN_LOGGING_OPTIONS} ${PROFILE} verify -pl ${e2e_modules} -DdistDir=$(readlink -e build-target)
 
 Review comment:
   I would be surprised if this actually works given that build-target should not exist in the current directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951777
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a510d137657ef2c71e27002f8852275080e7030b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385590395
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
 
 Review comment:
   It found the walkthrough modules?!
   
   ```
   2020-02-28T03:53:27.2778157Z [INFO] flink-cli-test ..................................... SUCCESS [  6.257 s]
   2020-02-28T03:53:27.2779191Z [INFO] flink-parent-child-classloading-test-program ....... SUCCESS [  0.374 s]
   2020-02-28T03:53:27.2780199Z [INFO] flink-parent-child-classloading-test-lib-package ... SUCCESS [  0.235 s]
   2020-02-28T03:53:27.2797292Z [INFO] flink-dataset-allround-test ........................ SUCCESS [  0.234 s]
   2020-02-28T03:53:27.2798579Z [INFO] flink-dataset-fine-grained-recovery-test ........... SUCCESS [  1.567 s]
   2020-02-28T03:53:27.2799589Z [INFO] flink-datastream-allround-test ..................... SUCCESS [  3.847 s]
   2020-02-28T03:53:27.2800549Z [INFO] flink-batch-sql-test ............................... SUCCESS [  0.272 s]
   2020-02-28T03:53:27.2813243Z [INFO] flink-stream-sql-test .............................. SUCCESS [  0.304 s]
   2020-02-28T03:53:27.2814296Z [INFO] flink-bucketing-sink-test .......................... SUCCESS [  3.753 s]
   2020-02-28T03:53:27.2815273Z [INFO] flink-distributed-cache-via-blob ................... SUCCESS [  0.270 s]
   2020-02-28T03:53:27.2816627Z [INFO] flink-high-parallelism-iterations-test ............. SUCCESS [  8.881 s]
   2020-02-28T03:53:27.2830226Z [INFO] flink-stream-stateful-job-upgrade-test ............. SUCCESS [  0.903 s]
   2020-02-28T03:53:27.2831268Z [INFO] flink-queryable-state-test ......................... SUCCESS [  1.892 s]
   2020-02-28T03:53:27.2832421Z [INFO] flink-local-recovery-and-allocation-test ........... SUCCESS [  0.139 s]
   2020-02-28T03:53:27.2835929Z [INFO] flink-elasticsearch5-test .......................... SUCCESS [  3.194 s]
   2020-02-28T03:53:27.2845579Z [INFO] flink-elasticsearch6-test .......................... SUCCESS [  3.591 s]
   2020-02-28T03:53:27.2846591Z [INFO] flink-quickstart-test .............................. SUCCESS [  0.269 s]
   2020-02-28T03:53:27.2847947Z [INFO] flink-confluent-schema-registry .................... SUCCESS [  1.587 s]
   2020-02-28T03:53:27.2858556Z [INFO] flink-stream-state-ttl-test ........................ SUCCESS [  3.828 s]
   2020-02-28T03:53:27.2859600Z [INFO] flink-sql-client-test .............................. SUCCESS [  1.137 s]
   2020-02-28T03:53:27.2860556Z [INFO] flink-streaming-file-sink-test ..................... SUCCESS [  0.150 s]
   2020-02-28T03:53:27.2861513Z [INFO] flink-state-evolution-test ......................... SUCCESS [  0.981 s]
   2020-02-28T03:53:27.2872757Z [INFO] flink-rocksdb-state-memory-control-test ............ SUCCESS [  0.950 s]
   2020-02-28T03:53:27.2873920Z [INFO] flink-end-to-end-tests-common ...................... SUCCESS [  1.967 s]
   2020-02-28T03:53:27.2874908Z [INFO] flink-metrics-availability-test .................... SUCCESS [ 16.337 s]
   2020-02-28T03:53:27.2876415Z [INFO] flink-metrics-reporter-prometheus-test ............. SUCCESS [ 17.309 s]
   2020-02-28T03:53:27.2887732Z [INFO] flink-heavy-deployment-stress-test ................. SUCCESS [  7.767 s]
   2020-02-28T03:53:27.2888749Z [INFO] flink-connector-gcp-pubsub-emulator-tests .......... SUCCESS [  1.046 s]
   2020-02-28T03:53:27.2889897Z [INFO] flink-streaming-kafka-test-base .................... SUCCESS [  0.403 s]
   2020-02-28T03:53:27.2891588Z [INFO] flink-streaming-kafka-test ......................... SUCCESS [  7.204 s]
   2020-02-28T03:53:27.2898790Z [INFO] flink-streaming-kafka011-test ...................... SUCCESS [  6.475 s]
   2020-02-28T03:53:27.2900043Z [INFO] flink-streaming-kafka010-test ...................... SUCCESS [  6.407 s]
   2020-02-28T03:53:27.2912375Z [INFO] flink-plugins-test ................................. SUCCESS [  0.073 s]
   2020-02-28T03:53:27.2913529Z [INFO] dummy-fs ........................................... SUCCESS [  0.160 s]
   2020-02-28T03:53:27.2914555Z [INFO] another-dummy-fs ................................... SUCCESS [  0.181 s]
   2020-02-28T03:53:27.2921875Z [INFO] flink-tpch-test .................................... SUCCESS [  0.940 s]
   2020-02-28T03:53:27.2929829Z [INFO] flink-streaming-kinesis-test ....................... SUCCESS [ 13.146 s]
   2020-02-28T03:53:27.2930929Z [INFO] flink-elasticsearch7-test .......................... SUCCESS [  3.704 s]
   2020-02-28T03:53:27.2932805Z [INFO] flink-end-to-end-tests-common-kafka ................ SUCCESS [02:17 min]
   2020-02-28T03:53:27.2944821Z [INFO] flink-tpcds-test ................................... SUCCESS [  0.310 s]
   2020-02-28T03:53:27.2945931Z [INFO] flink-walkthrough-common ........................... SUCCESS [  0.945 s]
   2020-02-28T03:53:27.2947182Z [INFO] flink-walkthrough-table-java ....................... SUCCESS [  3.092 s]
   2020-02-28T03:53:27.2948201Z [INFO] flink-walkthrough-table-scala ...................... SUCCESS [  0.183 s]
   2020-02-28T03:53:27.2959112Z [INFO] flink-walkthrough-datastream-java .................. SUCCESS [  0.191 s]
   2020-02-28T03:53:27.2960510Z [INFO] flink-walkthrough-datastream-scala ................. SUCCESS [  0.168 s]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385588817
 
 

 ##########
 File path: tools/azure-pipelines/free_disk_space.sh
 ##########
 @@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+echo "=============================================================================="
+echo "Freeing up disk space on CI system"
 
 Review comment:
   document why we do this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591949815
 
 
   CI != build system. I suggest to add a new Azure component to JIRA.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385612352
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -185,5 +198,32 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+set -x
+HERE="`dirname \"$0\"`"				# relative
 
 Review comment:
   Consider it gone :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385610776
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -185,5 +198,32 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+set -x
+HERE="`dirname \"$0\"`"				# relative
 
 Review comment:
   yes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951777
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150831939",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a510d137657ef2c71e27002f8852275080e7030b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150831939) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385591457
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
 
 Review comment:
   `HERE` is not used to resolve the modules. It is just used for the log4j file and the artifacts file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger closed pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385096166
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -185,5 +198,32 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
 
 Review comment:
   add the corresponding message for bash tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951777
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150831939",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a510d137657ef2c71e27002f8852275080e7030b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150831939) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385586458
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -185,5 +198,32 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+set -x
+HERE="`dirname \"$0\"`"				# relative
 
 Review comment:
   ping

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951777
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150831939",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5725",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150988521",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     }, {
       "hash" : "add563067625edba016094ec9b20813a25850255",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5730",
       "triggerID" : "add563067625edba016094ec9b20813a25850255",
       "triggerType" : "PUSH"
     }, {
       "hash" : "add563067625edba016094ec9b20813a25850255",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151001436",
       "triggerID" : "add563067625edba016094ec9b20813a25850255",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 096ad85a078405b0b8536d0d87e964889de82f75 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/150988521) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5725) 
   * add563067625edba016094ec9b20813a25850255 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151001436) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5730) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-592449563
 
 
   I pushed an update. Is there anything outstanding?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385589190
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -185,5 +198,32 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+set -x
+HERE="`dirname \"$0\"`"				# relative
 
 Review comment:
   are you talking about the horizontal whitespace?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591946288
 
 
   > Please add the appropriate component tags to the commit messages and PR title.
   
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385587834
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
 
 Review comment:
   This resolves to `flink/flink-end-to-end-tests`, no? (based on the code at the top, which is identical).
   If so, then you are excluding all walkthrough modules since we will not be found.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-592405848
 
 
   I have added a new JIRA component for Azure.
   
   I also did a major update of this PR. The end to end tests are now green (https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5707&view=results), and I think I added all end to end tests.
   
   I would appreciate if we could merge this quickly, to finally have overall green builds again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951777
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150831939",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5725",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150988521",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     }, {
       "hash" : "add563067625edba016094ec9b20813a25850255",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5730",
       "triggerID" : "add563067625edba016094ec9b20813a25850255",
       "triggerType" : "PUSH"
     }, {
       "hash" : "add563067625edba016094ec9b20813a25850255",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151001436",
       "triggerID" : "add563067625edba016094ec9b20813a25850255",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * add563067625edba016094ec9b20813a25850255 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151001436) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5730) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951777
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150831939",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a510d137657ef2c71e27002f8852275080e7030b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150831939) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691) 
   * 096ad85a078405b0b8536d0d87e964889de82f75 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385142236
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -161,69 +161,7 @@ run_test "Walkthrough Table Scala nightly end-to-end test" "$END_TO_END_DIR/test
 run_test "Walkthrough DataStream Java nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_datastream_walkthroughs.sh java"
 run_test "Walkthrough DataStream Scala nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_datastream_walkthroughs.sh scala"
 
-run_test "Test PubSub connector with Docker based Google PubSub Emulator" "$END_TO_END_DIR/test-scripts/test_streaming_gcp_pubsub.sh"
 
 Review comment:
   I now had 2 runs where all the end to end tests where passing.
   If I have another successful run, I will include all end to end tests in this PR. Stay tuned :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951198
 
 
   How about using the "Test Infrastructure" component for that?
   I'm also not the biggest fan of having "TravisX" as a build category in our code. What if we are switching our Ci system again?
   Ideally, in the code, we can call things "CIX"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385098188
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -185,5 +198,32 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+set -x
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
+if [ -z "${HERE}" ] ; then
+	# error; for some reason, the path is not accessible
+	# to the script (e.g. permissions re-evaled after suid)
+	exit 1  # fail
+fi
+ARTIFACTS_DIR="${HERE}/artifacts"
+mkdir -p $ARTIFACTS_DIR || { echo "FAILURE: cannot create log directory '${ARTIFACTS_DIR}'." ; exit 1; }
+
+LOG4J_PROPERTIES=${HERE}/../log4j-travis.properties
+
+MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} -Dlog4j.configurationFile=file://$LOG4J_PROPERTIES -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
+MVN_COMMON_OPTIONS="-nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -Dmaven.wagon.http.pool=false -Dfast -Pskip-webui-build"
+e2e_modules=$(find flink-end-to-end-tests -mindepth 2 -maxdepth 5 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')
+e2e_modules="${e2e_modules},$(find flink-walkthroughs -mindepth 2 -maxdepth 2 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')"
+
+PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6"
+mvn ${MVN_COMMON_OPTIONS} ${MVN_LOGGING_OPTIONS} ${PROFILE} verify -pl ${e2e_modules} -DdistDir=$(readlink -e build-target)
+
+
 printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
 
 Review comment:
   can be removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591945676
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6edfe213e845b05583807b46c4b0c078c371a276 (Thu Feb 27 12:29:14 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385099553
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -161,69 +161,7 @@ run_test "Walkthrough Table Scala nightly end-to-end test" "$END_TO_END_DIR/test
 run_test "Walkthrough DataStream Java nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_datastream_walkthroughs.sh java"
 run_test "Walkthrough DataStream Scala nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_datastream_walkthroughs.sh scala"
 
-run_test "Test PubSub connector with Docker based Google PubSub Emulator" "$END_TO_END_DIR/test-scripts/test_streaming_gcp_pubsub.sh"
 
 Review comment:
   I know some people use this file to run things locally; so this may break someone's workflow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385103236
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -161,69 +161,7 @@ run_test "Walkthrough Table Scala nightly end-to-end test" "$END_TO_END_DIR/test
 run_test "Walkthrough DataStream Java nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_datastream_walkthroughs.sh java"
 run_test "Walkthrough DataStream Scala nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_datastream_walkthroughs.sh scala"
 
-run_test "Test PubSub connector with Docker based Google PubSub Emulator" "$END_TO_END_DIR/test-scripts/test_streaming_gcp_pubsub.sh"
 
 Review comment:
   I was considering setting up another file like this for the ci runs (but then it would be even harder to keep things in sync)
   
   Given how aggressive the end to end test scripts modify things on the file system, I doubt that many people use these scripts.
   That's why I decided for this approach.
   
   How about keeping this file, and I comment out, instead of deleting?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951777
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150831939",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5725",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150988521",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a510d137657ef2c71e27002f8852275080e7030b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150831939) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691) 
   * 096ad85a078405b0b8536d0d87e964889de82f75 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150988521) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5725) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385590062
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -182,5 +205,29 @@ run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR
 run_test "Local recovery and sticky scheduling end-to-end test" "$END_TO_END_DIR/test-scripts/test_local_recovery_and_scheduling.sh 4 10 rocks true true" "skip_check_exceptions"
 
 printf "\n[PASS] All bash e2e-tests passed\n"
-printf "\n Please remember to run java e2e-tests by running mvn verify -Dcategories=\"\" -DdistDir=<path to flink-dist> in flink-end-to-end-tests\n"
+
+printf "\n\n==============================================================================\n"
+printf "Running Java end-to-end tests\n"
+printf "==============================================================================\n"
+
+HERE="`dirname \"$0\"`"				# relative
+HERE="`( cd \"${HERE}\" && pwd -P)`" 	# absolutized and normalized
+if [ -z "${HERE}" ] ; then
+	# error; for some reason, the path is not accessible
+	# to the script (e.g. permissions re-evaled after suid)
+	exit 1  # fail
+fi
+ARTIFACTS_DIR="${HERE}/artifacts"
+mkdir -p $ARTIFACTS_DIR || { echo "FAILURE: cannot create log directory '${ARTIFACTS_DIR}'." ; exit 1; }
+
+LOG4J_PROPERTIES=${HERE}/../tools/log4j-travis.properties
+
+MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} -Dlog4j.configurationFile=file://$LOG4J_PROPERTIES -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
+MVN_COMMON_OPTIONS="-nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -Dmaven.wagon.http.pool=false -Dfast -Pskip-webui-build"
+e2e_modules=$(find flink-end-to-end-tests -mindepth 2 -maxdepth 5 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')
+e2e_modules="${e2e_modules},$(find flink-walkthroughs -mindepth 2 -maxdepth 2 -name 'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')"
+
+PROFILE="$PROFILE -Pe2e-travis1 -Pe2e-travis2 -Pe2e-travis3 -Pe2e-travis4 -Pe2e-travis5 -Pe2e-travis6"
+mvn ${MVN_COMMON_OPTIONS} ${MVN_LOGGING_OPTIONS} ${PROFILE} verify -pl ${e2e_modules} -DdistDir=$(readlink -e build-target)
 
 Review comment:
   This has worked in a build last night: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=5709&view=logs&j=b1623ac9-0979-5b0d-2e5e-1377d695c991&t=e7804547-1789-5225-2bcf-269eeaa37447

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-592109917
 
 
   Test infrastructure is for junit/maven stuff. There's little reason why, for example, some caching change for azure should be marked as such.
   
   I'm perfectly content with having travis/azure as categories. It frees the azure category of all the baggage from the past.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#issuecomment-591951777
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a510d137657ef2c71e27002f8852275080e7030b",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150831939",
       "triggerID" : "a510d137657ef2c71e27002f8852275080e7030b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5725",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     }, {
       "hash" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150988521",
       "triggerID" : "096ad85a078405b0b8536d0d87e964889de82f75",
       "triggerType" : "PUSH"
     }, {
       "hash" : "add563067625edba016094ec9b20813a25850255",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "add563067625edba016094ec9b20813a25850255",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a510d137657ef2c71e27002f8852275080e7030b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150831939) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5691) 
   * 096ad85a078405b0b8536d0d87e964889de82f75 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150988521) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5725) 
   * add563067625edba016094ec9b20813a25850255 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests
URL: https://github.com/apache/flink/pull/11241#discussion_r385098549
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -173,6 +183,9 @@ run_test "ConnectedComponents iterations with high parallelism end-to-end test"
 
 run_test "Dependency shading of table modules test" "$END_TO_END_DIR/test-scripts/test_table_shaded_dependencies.sh"
 
+run_test "Shaded Hadoop S3A with credentials provider end-to-end test" "$END_TO_END_DIR/test-scripts/test_batch_wordcount.sh hadoop_with_provider"
+
+
 
 Review comment:
   remove one empty line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services