[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1945: And multi-path in RowsetGraph

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #1945: And multi-path in RowsetGraph
URL: https://github.com/apache/incubator-doris/pull/1945#discussion_r334216124
 
 

 ##########
 File path: be/src/olap/compaction.cpp
 ##########
 @@ -110,44 +110,22 @@ OLAPStatus Compaction::construct_input_rowset_readers() {
     return OLAP_SUCCESS;
 }
 
-OLAPStatus Compaction::modify_rowsets() {
+OLAPStatus Compaction::add_rowsets() {
     std::vector<RowsetSharedPtr> output_rowsets;
     output_rowsets.push_back(_output_rowset);
     
-    WriteLock wrlock(_tablet->get_header_lock_ptr());
-    OLAPStatus res = _tablet->modify_rowsets(output_rowsets, _input_rowsets);
+    OLAPStatus res = _tablet->add_rowsets(output_rowsets);
 
 Review comment:
   I will call add_rowset() instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org