[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37452: [SPARK-40018][SQL][TESTS] Output `SparkThrowable` to SQL golden files in JSON format

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #37452:
URL: https://github.com/apache/spark/pull/37452#discussion_r941929812


##########
sql/core/src/test/resources/sql-tests/results/ansi/array.sql.out:
##########
@@ -128,7 +128,7 @@ select sort_array(array('b', 'd'), '1')
 struct<>
 -- !query output
 org.apache.spark.sql.AnalysisException
-cannot resolve 'sort_array(array('b', 'd'), '1')' due to data type mismatch: Sort order in second argument requires a boolean literal.; line 1 pos 7
+{"errorClass":null,"messageParameters":[],"queryContext":[]}

Review Comment:
   Hm, it's a bit odd to me that the user-facing error contains JSON exception. e.g., if you run it in `spark-sql` then users would face such JSON encoded string .. that I don't think it's good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org