[GitHub] [helix] narendly edited a comment on issue #690: Reset the WAGED rebalancer once the controller newly acquires leadership.

[GitBox <gi...@apache.org>]

narendly edited a comment on issue #690: Reset the WAGED rebalancer once the controller newly acquires leadership.
URL: https://github.com/apache/helix/pull/690#issuecomment-577429092
 
 
   @jiajunwang Could we separate the scope for this change?
   
   1. Is it possible to create a PR that includes the change on resetting the cluster data change detector?
   2. The next PR would be the movement of the rebalancer to Generic Helix Controller. It's not too clear why this is necessary 
   
   > Move the stateful WAGED rebalancer to the GenericHelixController object instead of the rebalance stage. This is for resolving the possible race condition between the event processing thread and leader switch handling thread.
   
   Could you explain this further? I am afraid in terms of design, we might be introducing a new dependency (between GenericHelixController and the rebalancer/stages). This doesn't seem too great to me because Helix's design I believe aims to keep them independent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org