You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/10 08:27:59 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #1222: cxd56 audio with buffering
masayuki2009 opened a new pull request #1222:
URL: https://github.com/apache/incubator-nuttx/pull/1222
## Summary
- This PR consists for 3 commits for spresense audio.
- The first commit handles the final audio buffer to send stop message. In previous implementation, the final audio buffer was not handled. Thus, audio driver always stopped after detecting dma underrun. With this commit, audio driver stops correctly at the end of audio file.
- The second commit add audio buffering feature to audio/cxd56. In this implementation, CXD56_DEV_STATE_BUFFERING is newly added to distinguish from pause state for buffering. And if pending queue is empty in cxd56_start_dma(), it sends AUDIO_MSG_USER to the worker thread to start buffering. In the worker thread, it sets CXD56_DEV_STATE_BUFFERING when received AUDIO_MSG_USER. Then if AUDIO_MSG_ENQUEUE received, it checks conditions such as pendingq exceeds the threshold or pendingq contains the final buffer and if it matches the condition then start dma again by calling cxd56_resume().
- The third commit adjusts audio buffer (4KB x 32 -> 2KB x 32) and prealloc mq size (4 -> 32) for audio streaming with wifi.
## Impact
- This PR affects spresense audio driver and wifi configuration.
## Testing
- I tested this PR with nxplayer for both local file playback and http audio streaming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #1222: cxd56 audio with buffering
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1222:
URL: https://github.com/apache/incubator-nuttx/pull/1222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1222: cxd56 audio with buffering
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1222:
URL: https://github.com/apache/incubator-nuttx/pull/1222#issuecomment-642308661
Hi @jerpelea , @tobias2johansson,
I'm sorry to forgot to leave comments for review before merging.
I thought I had left comments...
Anyway, as you can see, I added a buffering feature to cxd56 audio and
if you have any concerns, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #1222: cxd56 audio with buffering
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1222:
URL: https://github.com/apache/incubator-nuttx/pull/1222#issuecomment-643166716
The PR message looks good and should be replicated in the commit messages
@masayuki2009 please add commit messages
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org