You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2009/02/11 12:17:04 UTC
[jira] Created: (QPID-1659) Several tests wrap AMQMessages rather
than overriding functionality
Several tests wrap AMQMessages rather than overriding functionality
-------------------------------------------------------------------
Key: QPID-1659
URL: https://issues.apache.org/jira/browse/QPID-1659
Project: Qpid
Issue Type: Improvement
Components: Java Tests
Affects Versions: M4
Reporter: Martin Ritchie
Priority: Minor
Fix For: M5
These tests all use the MessageFactory to create a new message but then use that as the basis for their own Message classes:
SimpleAMQQueueTest, TxAckTest.TestMessage, AbstractHeaderExchangeTestBase.Message
Their own classes already extend the right base type so they do not need to use the MessageFactory.
By simply overriding the right methods of the AMQMessage they would not need to have a custom Constructor on the TransientAMQMessasge Class.
This constructor is now marked Deprecated and should be removed at the earliest opportunity.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1659) Several tests wrap AMQMessages rather
than overriding functionality
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1659:
---------------------------------
Fix Version/s: (was: M5)
Affects Version/s: M5
> Several tests wrap AMQMessages rather than overriding functionality
> -------------------------------------------------------------------
>
> Key: QPID-1659
> URL: https://issues.apache.org/jira/browse/QPID-1659
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Affects Versions: M4, M5
> Reporter: Martin Ritchie
> Priority: Minor
>
> These tests all use the MessageFactory to create a new message but then use that as the basis for their own Message classes:
> SimpleAMQQueueTest, TxAckTest.TestMessage, AbstractHeaderExchangeTestBase.Message
> Their own classes already extend the right base type so they do not need to use the MessageFactory.
> By simply overriding the right methods of the AMQMessage they would not need to have a custom Constructor on the TransientAMQMessasge Class.
> This constructor is now marked Deprecated and should be removed at the earliest opportunity.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org