You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wzx140 (via GitHub)" <gi...@apache.org> on 2024/12/11 07:02:34 UTC
[I] Comment and assertion mismatch in PartitionedWritesTestBase [iceberg]
wzx140 opened a new issue, #11747:
URL: https://github.com/apache/iceberg/issues/11747
### Apache Iceberg version
main (development)
### Query engine
Spark
### Please describe the bug 🐞
There is a mismatch between the test comment and the assertion in the following unit test, which might lead to confusion or logical errors.
Here is the relevant code snippet:
```java
@TestTemplate
public void testInsertAppend() {
assertThat(scalarSql("SELECT count(*) FROM %s", selectTarget()))
.as("Should have 5 rows after insert")
.isEqualTo(3L);
```
- The comment "Should have 5 rows after insert" indicates the expectation of 5 rows in the table.
- However, the actual assertion isEqualTo(3L) checks for 3 rows instead.
### Willingness to contribute
- [X] I can contribute a fix for this bug independently
- [X] I would be willing to contribute a fix for this bug with guidance from the Iceberg community
- [ ] I cannot contribute a fix for this bug at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Comment and assertion mismatch in PartitionedWritesTestBase/TestRewritePositionDeleteFilesAction [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho closed issue #11747: Comment and assertion mismatch in PartitionedWritesTestBase/TestRewritePositionDeleteFilesAction
URL: https://github.com/apache/iceberg/issues/11747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org