You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@juneau.apache.org by GitBox <gi...@apache.org> on 2019/10/12 09:03:32 UTC
[GitHub] [juneau-petstore] ishita20 opened a new pull request #2: JUNEAU-152
Added a Dockerfile to run app using war file
ishita20 opened a new pull request #2: JUNEAU-152 Added a Dockerfile to run app using war file
URL: https://github.com/apache/juneau-petstore/pull/2
The current Dockerfile has steps to only run the war file. Should I also add steps to build the app and use the war file from this build itself?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [juneau-petstore] ishita20 opened a new pull request #2:
JUNEAU-152 Added a Dockerfile to run app using war file
Posted by James Bognar <ja...@apache.org>.
I've merged the change. Looks good!
I suggest we update the documentation found here:
http://juneau.apache.org/index.html#petstore.html
The source for this can be found in the following repo:
https://github.com/apache/juneau-website
The file is juneau-website/content/petstore.html.
On Sun, Oct 13, 2019 at 9:28 AM Ishita Singh <is...@gmail.com> wrote:
>
> Hi,
>
> Do I need to make any changes? I shall start with the documentation once this is finalized.
>
> Thanks.
>
> ---------- Forwarded message ---------
> From: GitBox <gi...@apache.org>
> Date: Sat 12 Oct, 2019, 2:33 PM
> Subject: [GitHub] [juneau-petstore] ishita20 opened a new pull request #2: JUNEAU-152 Added a Dockerfile to run app using war file
> To: <de...@juneau.apache.org>
>
>
> ishita20 opened a new pull request #2: JUNEAU-152 Added a Dockerfile to run app using war file
> URL: https://github.com/apache/juneau-petstore/pull/2
>
>
> The current Dockerfile has steps to only run the war file. Should I also add steps to build the app and use the war file from this build itself?
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services