You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Jeremias Maerki <de...@jeremias-maerki.ch> on 2005/10/13 17:39:20 UTC
Volunteer wanted - disabled-testcases.txt in XML
I've had a idea, hopefully a good one. If the disabled-testcases.txt
were rewritten as an XML file additional information could be added to
each disabled test case why it is disabled. This information could be
transformed by Forrest into a page ("known issues") for our website. And
it could even be used as content for a release notes document.
Example:
block-container_reference-orientation_bug36391.xml
block_font-stretch.xml
....
becomes:
<disabled-testcases>
<testcase name="block-container_reference-orientation_bug36391" bugzilla="36391">
Blah describes the deficiency of the test case blah.
</testcase>
<testcase name="block_font-stretch">
font-stretch is not implemented, yet.
</testcase>
....
</disabled-testcases>
Anyone want to take a stab? No knowledge about FOP internals needed.
Jeremias Maerki
Re: Volunteer wanted - disabled-testcases.txt in XML
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Look here:
http://offo.sourceforge.net/hyphenation/
http://sourceforge.net/project/showfiles.php?group_id=116740
(Download the one for "fop-HEAD")
On 20.10.2005 23:10:43 Mark Gaywood wrote:
> Jeremias
>
> Trying to ru the testcases, but I can't put my hands on en.hyp or de.hyp.
> Can you point me in the direction of them?
>
> Mark
>
> On 19/10/05, Jeremias Maerki <de...@jeremias-maerki.ch> wrote:
> >
> > A single XML file as I showed it in my first post. That's more easily
> > processed later when we put this information on the website.
> >
> > On 19.10.2005 00:22:39 Mark Gaywood wrote:
> > > Hi
> > >
> > > Sorry for the delay, but I've got some clear evenings ahead.
> > >
> > > With the text file (disabled-testcases.txt) are you envisioning a single
> > xml
> > > replacement or one xml for each testcase?
> > >
> > > Mark
> > >
> > > -----Original Message-----
> > >
> > > From: Jeremias Maerki [*mailto:dev@jeremias-maerki.ch*<
> > dev@jeremias-maerki.ch>]
> > >
> > >
> > > Sent: 15 October 2005 07:52
> > >
> > > To: fop-dev@xmlgraphics.apache.org
> > >
> > > Subject: Re: Volunteer wanted - disabled-testcases.txt in XML
> > >
> > > Only a couple of things to add to what Clay already handled.
> > >
> > > On 15.10.2005 02:02:39 Mark Gaywood wrote:
> > >
> > > > Jeremias,
> > >
> > > >
> > >
> > > > I'm set and ready to, just to be clear and I do apologise for not
> > >
> > > > being on the ball straight away with what must appear to be a trivial
> > >
> > > > task to most of you ,but I hope to up to your speeds and skill very
> > >
> > > > soon.
> > >
> > > >
> > >
> > > > 1. convert the text file into an xml document with previously suggest
> > >
> > > > markup
> > >
> > > Yes.
> > >
> > > > 2. modify decorateWithDisabledList to load the XML document
> > >
> > > Yes.
> > >
> > > > 3. filter the output of decorateWithDisabledList based a lookup passed
> > >
> > > > in? Would it be too much to ask for you give me an example of an input
> > >
> > > > and output for this method?
> > >
> > > The mechanism in use here is the filefilter package from Jakarta Commons
> > IO.
> > > You find the documentation here: *
> > >
> > http://jakarta.apache.org/commons/io/api-release/index.html?org/apache/commons/io/filefilter/package-summary.html
> > > *<
> > http://jakarta.apache.org/commons/io/api-release/index.html?org/apache/commons/io/filefilter/package-summary.html
> > >
> > >
> > > This method doesn't filter the files directly but decorates (See Design
> > > Patterns, "Gang of Four") an existing file filter so that the files
> > listed
> > > in the file you're about to convert to XML won't get returned by the
> > > FileUtils.listFiles() methods (also a Commons IO thing). Basically,
> > you're
> > > building a rule tree here. An example:
> > >
> > > Assume a simple filter:
> > >
> > > IOFileFilter myFilter = new PrefixFileFilter("my");
> > >
> > > Passed into FileUtils.listFiles() this filter will return all files that
> > > start with "my", i.e. for example "myStuff.txt".
> > >
> > > What you do in decorateWithDisabledList is something like that:
> > >
> > > myFilter = new AndFilter(myFilter, new SuffixFileFilter(".xml"));
> > >
> > > This will create a modified filter which restricts the existing file
> > filter
> > > by adding the rule that all returned files must be XML files, so "
> > > myStuff.txt" wouldn't be returned anymore, but "myCalendar.xml" will
> > still
> > > be returned.
> > >
> > > Basically, you don't modify the filefilter rule at all, just the way the
> > > NameFileFilter in decorateWithDisabledList is constructed.
> > >
> > > Run the whole thing through the debugger once and you'll understand how
> > this
> > > works.
> > >
> > > > 4. create some website with XSLT, Cocoon and Forrest (Nice)
> > >
> > > Yes, if you want to do it.
> > >
> > > > Will I need a password for login for submitting to SVN or would you
> > >
> > > > prefer another method of code submission?
> > >
> > > Just download the code using SVN and create patches as described in: *
> > > http://xmlgraphics.apache.org/fop/dev/#patches*<
> > http://xmlgraphics.apache.org/fop/dev/>
> > >
> > > and
> > >
> > > *http://xmlgraphics.apache.org/fop/dev/tools.html#patches*<
> > http://xmlgraphics.apache.org/fop/dev/tools.html>
> > >
> > > and submit them using Bugzilla as Clay already told you.
> > >
> > > Jeremias Maerki
> > > <'fop-dev@xmlgraphics.apache.org'>
> >
> >
> >
> > Jeremias Maerki
> >
> >
Jeremias Maerki
Re: Volunteer wanted - disabled-testcases.txt in XML
Posted by Mark Gaywood <fo...@gmail.com>.
Jeremias
Trying to ru the testcases, but I can't put my hands on en.hyp or de.hyp.
Can you point me in the direction of them?
Mark
On 19/10/05, Jeremias Maerki <de...@jeremias-maerki.ch> wrote:
>
> A single XML file as I showed it in my first post. That's more easily
> processed later when we put this information on the website.
>
> On 19.10.2005 00:22:39 Mark Gaywood wrote:
> > Hi
> >
> > Sorry for the delay, but I've got some clear evenings ahead.
> >
> > With the text file (disabled-testcases.txt) are you envisioning a single
> xml
> > replacement or one xml for each testcase?
> >
> > Mark
> >
> > -----Original Message-----
> >
> > From: Jeremias Maerki [*mailto:dev@jeremias-maerki.ch*<
> dev@jeremias-maerki.ch>]
> >
> >
> > Sent: 15 October 2005 07:52
> >
> > To: fop-dev@xmlgraphics.apache.org
> >
> > Subject: Re: Volunteer wanted - disabled-testcases.txt in XML
> >
> > Only a couple of things to add to what Clay already handled.
> >
> > On 15.10.2005 02:02:39 Mark Gaywood wrote:
> >
> > > Jeremias,
> >
> > >
> >
> > > I'm set and ready to, just to be clear and I do apologise for not
> >
> > > being on the ball straight away with what must appear to be a trivial
> >
> > > task to most of you ,but I hope to up to your speeds and skill very
> >
> > > soon.
> >
> > >
> >
> > > 1. convert the text file into an xml document with previously suggest
> >
> > > markup
> >
> > Yes.
> >
> > > 2. modify decorateWithDisabledList to load the XML document
> >
> > Yes.
> >
> > > 3. filter the output of decorateWithDisabledList based a lookup passed
> >
> > > in? Would it be too much to ask for you give me an example of an input
> >
> > > and output for this method?
> >
> > The mechanism in use here is the filefilter package from Jakarta Commons
> IO.
> > You find the documentation here: *
> >
> http://jakarta.apache.org/commons/io/api-release/index.html?org/apache/commons/io/filefilter/package-summary.html
> > *<
> http://jakarta.apache.org/commons/io/api-release/index.html?org/apache/commons/io/filefilter/package-summary.html
> >
> >
> > This method doesn't filter the files directly but decorates (See Design
> > Patterns, "Gang of Four") an existing file filter so that the files
> listed
> > in the file you're about to convert to XML won't get returned by the
> > FileUtils.listFiles() methods (also a Commons IO thing). Basically,
> you're
> > building a rule tree here. An example:
> >
> > Assume a simple filter:
> >
> > IOFileFilter myFilter = new PrefixFileFilter("my");
> >
> > Passed into FileUtils.listFiles() this filter will return all files that
> > start with "my", i.e. for example "myStuff.txt".
> >
> > What you do in decorateWithDisabledList is something like that:
> >
> > myFilter = new AndFilter(myFilter, new SuffixFileFilter(".xml"));
> >
> > This will create a modified filter which restricts the existing file
> filter
> > by adding the rule that all returned files must be XML files, so "
> > myStuff.txt" wouldn't be returned anymore, but "myCalendar.xml" will
> still
> > be returned.
> >
> > Basically, you don't modify the filefilter rule at all, just the way the
> > NameFileFilter in decorateWithDisabledList is constructed.
> >
> > Run the whole thing through the debugger once and you'll understand how
> this
> > works.
> >
> > > 4. create some website with XSLT, Cocoon and Forrest (Nice)
> >
> > Yes, if you want to do it.
> >
> > > Will I need a password for login for submitting to SVN or would you
> >
> > > prefer another method of code submission?
> >
> > Just download the code using SVN and create patches as described in: *
> > http://xmlgraphics.apache.org/fop/dev/#patches*<
> http://xmlgraphics.apache.org/fop/dev/>
> >
> > and
> >
> > *http://xmlgraphics.apache.org/fop/dev/tools.html#patches*<
> http://xmlgraphics.apache.org/fop/dev/tools.html>
> >
> > and submit them using Bugzilla as Clay already told you.
> >
> > Jeremias Maerki
> > <'fop-dev@xmlgraphics.apache.org'>
>
>
>
> Jeremias Maerki
>
>
Re: Volunteer wanted - disabled-testcases.txt in XML
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
A single XML file as I showed it in my first post. That's more easily
processed later when we put this information on the website.
On 19.10.2005 00:22:39 Mark Gaywood wrote:
> Hi
>
> Sorry for the delay, but I've got some clear evenings ahead.
>
> With the text file (disabled-testcases.txt) are you envisioning a single xml
> replacement or one xml for each testcase?
>
> Mark
>
> -----Original Message-----
>
> From: Jeremias Maerki [*mailto:dev@jeremias-maerki.ch*<de...@jeremias-maerki.ch>]
>
>
> Sent: 15 October 2005 07:52
>
> To: fop-dev@xmlgraphics.apache.org
>
> Subject: Re: Volunteer wanted - disabled-testcases.txt in XML
>
> Only a couple of things to add to what Clay already handled.
>
> On 15.10.2005 02:02:39 Mark Gaywood wrote:
>
> > Jeremias,
>
> >
>
> > I'm set and ready to, just to be clear and I do apologise for not
>
> > being on the ball straight away with what must appear to be a trivial
>
> > task to most of you ,but I hope to up to your speeds and skill very
>
> > soon.
>
> >
>
> > 1. convert the text file into an xml document with previously suggest
>
> > markup
>
> Yes.
>
> > 2. modify decorateWithDisabledList to load the XML document
>
> Yes.
>
> > 3. filter the output of decorateWithDisabledList based a lookup passed
>
> > in? Would it be too much to ask for you give me an example of an input
>
> > and output for this method?
>
> The mechanism in use here is the filefilter package from Jakarta Commons IO.
> You find the documentation here: *
> http://jakarta.apache.org/commons/io/api-release/index.html?org/apache/commons/io/filefilter/package-summary.html
> *<http://jakarta.apache.org/commons/io/api-release/index.html?org/apache/commons/io/filefilter/package-summary.html>
>
> This method doesn't filter the files directly but decorates (See Design
> Patterns, "Gang of Four") an existing file filter so that the files listed
> in the file you're about to convert to XML won't get returned by the
> FileUtils.listFiles() methods (also a Commons IO thing). Basically, you're
> building a rule tree here. An example:
>
> Assume a simple filter:
>
> IOFileFilter myFilter = new PrefixFileFilter("my");
>
> Passed into FileUtils.listFiles() this filter will return all files that
> start with "my", i.e. for example "myStuff.txt".
>
> What you do in decorateWithDisabledList is something like that:
>
> myFilter = new AndFilter(myFilter, new SuffixFileFilter(".xml"));
>
> This will create a modified filter which restricts the existing file filter
> by adding the rule that all returned files must be XML files, so "
> myStuff.txt" wouldn't be returned anymore, but "myCalendar.xml" will still
> be returned.
>
> Basically, you don't modify the filefilter rule at all, just the way the
> NameFileFilter in decorateWithDisabledList is constructed.
>
> Run the whole thing through the debugger once and you'll understand how this
> works.
>
> > 4. create some website with XSLT, Cocoon and Forrest (Nice)
>
> Yes, if you want to do it.
>
> > Will I need a password for login for submitting to SVN or would you
>
> > prefer another method of code submission?
>
> Just download the code using SVN and create patches as described in: *
> http://xmlgraphics.apache.org/fop/dev/#patches*<http://xmlgraphics.apache.org/fop/dev/>
>
> and
>
> *http://xmlgraphics.apache.org/fop/dev/tools.html#patches*<http://xmlgraphics.apache.org/fop/dev/tools.html>
>
> and submit them using Bugzilla as Clay already told you.
>
> Jeremias Maerki
> <'fop-dev@xmlgraphics.apache.org'>
Jeremias Maerki
Re: Volunteer wanted - disabled-testcases.txt in XML
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Only a couple of things to add to what Clay already handled.
On 15.10.2005 02:02:39 Mark Gaywood wrote:
> Jeremias,
>
> I'm set and ready to, just to be clear and I do apologise for not
> being on the ball straight away with what must appear to be a trivial
> task to most of you ,but I hope to up to your speeds and skill very
> soon.
>
> 1. convert the text file into an xml document with previously suggest markup
Yes.
> 2. modify decorateWithDisabledList to load the XML document
Yes.
> 3. filter the output of decorateWithDisabledList based a lookup passed
> in? Would it be too much to ask for you give me an example of an input
> and output for this method?
The mechanism in use here is the filefilter package from Jakarta Commons
IO. You find the documentation here:
http://jakarta.apache.org/commons/io/api-release/index.html?org/apache/commons/io/filefilter/package-summary.html
This method doesn't filter the files directly but decorates (See Design
Patterns, "Gang of Four") an existing file filter so that the files
listed in the file you're about to convert to XML won't get returned by
the FileUtils.listFiles() methods (also a Commons IO thing). Basically,
you're building a rule tree here. An example:
Assume a simple filter:
IOFileFilter myFilter = new PrefixFileFilter("my");
Passed into FileUtils.listFiles() this filter will return all files that
start with "my", i.e. for example "myStuff.txt".
What you do in decorateWithDisabledList is something like that:
myFilter = new AndFilter(myFilter, new SuffixFileFilter(".xml"));
This will create a modified filter which restricts the existing file
filter by adding the rule that all returned files must be XML files, so
"myStuff.txt" wouldn't be returned anymore, but "myCalendar.xml" will
still be returned.
Basically, you don't modify the filefilter rule at all, just the way the
NameFileFilter in decorateWithDisabledList is constructed.
Run the whole thing through the debugger once and you'll understand how
this works.
> 4. create some website with XSLT, Cocoon and Forrest (Nice)
Yes, if you want to do it.
> Will I need a password for login for submitting to SVN or would you
> prefer another method of code submission?
Just download the code using SVN and create patches as described in:
http://xmlgraphics.apache.org/fop/dev/#patches
and
http://xmlgraphics.apache.org/fop/dev/tools.html#patches
and submit them using Bugzilla as Clay already told you.
Jeremias Maerki
Re: Volunteer wanted - disabled-testcases.txt in XML
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
You'll have to unsubscribe the old address and resubscribe with the new
one: empty mail to fop-dev-unsubscribe@xmlgraphics.apache.org to
unsubscribe, empty mail to fop-dev-subscribe@xmlgraphics.apache.org from
the other account to subscribe again.
On 14.10.2005 10:39:13 Gaywood, Mark wrote:
> I'll get started this evening, is it possible to change my registered
> email to mark.gaywood@catlin.com to fopdev@gmail.com, as I can't get to
> the work email from home.
>
> Thanks
> Mark Gaywood
>
>
>
> -----Original Message-----
> From: Jeremias Maerki [mailto:dev@jeremias-maerki.ch]
> Sent: Thursday, October 13, 2005 6:09 PM
> To: fop-dev@xmlgraphics.apache.org
> Subject: Re: Volunteer wanted - disabled-testcases.txt in XML
>
>
> Great!
>
> So the main task would be to modify the static method
> "decorateWithDisabledList(IOFileFilter)" in
> test/java/org/apache/fop/layoutengine/LayoutEngineTestSuite.java so it
> loads the new XML file instead of the old disabled-testcases.txt and
> builds the filter according to the entries in there.
>
> If you'd like to create the website page, too, that's probably going to
> be a little more difficult as it involves setting up a special XSLT in
> the Cocoon sitemap for the Forrest website. But it could be an
> interesting thing to do. No problem if you only do the first part.
>
> Looking forward to your patch! Proves that it's sometimes simply a
> matter of calling for help and you get it. Thanks, Mark! If you need any
> more info, just ask.
>
> On 13.10.2005 18:13:18 Gaywood, Mark wrote:
> > I could spare an hour most evenings, if that's enough.
> >
> > Mark Gaywood
> >
> >
> >
> > -----Original Message-----
> > From: Jeremias Maerki [mailto:dev@jeremias-maerki.ch]
> > Sent: Thursday, October 13, 2005 4:39 PM
> > To: fop-dev@xmlgraphics.apache.org
> > Subject: Volunteer wanted - disabled-testcases.txt in XML
> >
> >
> > I've had a idea, hopefully a good one. If the disabled-testcases.txt
> > were rewritten as an XML file additional information could be added to
>
> > each disabled test case why it is disabled. This information could be
> > transformed by Forrest into a page ("known issues") for our website.
> > And it could even be used as content for a release notes document.
> >
> > Example:
> >
> > block-container_reference-orientation_bug36391.xml
> > block_font-stretch.xml
> > ....
> >
> > becomes:
> >
> > <disabled-testcases>
> > <testcase name="block-container_reference-orientation_bug36391"
> > bugzilla="36391">
> > Blah describes the deficiency of the test case blah.
> > </testcase>
> > <testcase name="block_font-stretch">
> > font-stretch is not implemented, yet.
> > </testcase>
> > ....
> > </disabled-testcases>
> >
> > Anyone want to take a stab? No knowledge about FOP internals needed.
> >
> > Jeremias Maerki
> >
> >
> >
> > This e-mail is confidential and intended solely for the use of the
> > individual(s) to whom it is addressed. If you are not the intended
> > recipient, be advised that you have received this e-mail in error and
> > that any use, dissemination, forwarding, printing, copying of , or any
>
> > action taken in reliance upon, it is strictly prohibited and may be
> > illegal.
>
>
>
> Jeremias Maerki
>
>
>
> This e-mail is confidential and intended solely for the use of the individual(s) to whom it is addressed. If you are not the intended recipient, be advised that you have received this e-mail in error and that any use, dissemination, forwarding, printing, copying of , or any action taken in reliance upon, it is strictly prohibited and may be illegal.
Jeremias Maerki
Re: Volunteer wanted - disabled-testcases.txt in XML
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Great!
So the main task would be to modify the static method
"decorateWithDisabledList(IOFileFilter)" in
test/java/org/apache/fop/layoutengine/LayoutEngineTestSuite.java so it
loads the new XML file instead of the old disabled-testcases.txt and
builds the filter according to the entries in there.
If you'd like to create the website page, too, that's probably going to
be a little more difficult as it involves setting up a special XSLT in
the Cocoon sitemap for the Forrest website. But it could be an
interesting thing to do. No problem if you only do the first part.
Looking forward to your patch! Proves that it's sometimes simply a
matter of calling for help and you get it. Thanks, Mark! If you need any
more info, just ask.
On 13.10.2005 18:13:18 Gaywood, Mark wrote:
> I could spare an hour most evenings, if that's enough.
>
> Mark Gaywood
>
>
>
> -----Original Message-----
> From: Jeremias Maerki [mailto:dev@jeremias-maerki.ch]
> Sent: Thursday, October 13, 2005 4:39 PM
> To: fop-dev@xmlgraphics.apache.org
> Subject: Volunteer wanted - disabled-testcases.txt in XML
>
>
> I've had a idea, hopefully a good one. If the disabled-testcases.txt
> were rewritten as an XML file additional information could be added to
> each disabled test case why it is disabled. This information could be
> transformed by Forrest into a page ("known issues") for our website. And
> it could even be used as content for a release notes document.
>
> Example:
>
> block-container_reference-orientation_bug36391.xml
> block_font-stretch.xml
> ....
>
> becomes:
>
> <disabled-testcases>
> <testcase name="block-container_reference-orientation_bug36391"
> bugzilla="36391">
> Blah describes the deficiency of the test case blah.
> </testcase>
> <testcase name="block_font-stretch">
> font-stretch is not implemented, yet.
> </testcase>
> ....
> </disabled-testcases>
>
> Anyone want to take a stab? No knowledge about FOP internals needed.
>
> Jeremias Maerki
>
>
>
> This e-mail is confidential and intended solely for the use of the individual(s) to whom it is addressed. If you are not the intended recipient, be advised that you have received this e-mail in error and that any use, dissemination, forwarding, printing, copying of , or any action taken in reliance upon, it is strictly prohibited and may be illegal.
Jeremias Maerki