[jira] Commented: (SOLR-2314) replicate/index.jsp UI does not work with repeaters (both master and slave)

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983515#action_12983515 ] 

Hoss Man commented on SOLR-2314:
--------------------------------

The more i look at this issue, the less i understand it.  testing on the trunk (where index.jsp is identical to the 1.4.1 release)...

* if i use a solrconfig.xml with only master settings, the h1 tag on the page includes "Master" and there are three pieces of data (Index Version, Location, and Size)
* if i use a solrconfig.xml with only slave settings, the h1 tag on the page includes "Slave" and there are numerous additional pieces of information, *including all three property returned as a master*
* if i use a solconfig.xml with both slave and master settings, the h1 tag includes "Master & Slave" and i get all of same data as before
* this behavior doesn't change if i leave both the master/slave settings in the handler config, and use an "enable" attribute to activate them
* all of this behavior remains the same regardless of whether i use a system property to drive the enable attributes.

So based on that, i don't see a bug indicating that master details (or slave details) are displayed incorrectly by index.jsp when only one type is in use, but not when a box is a repeater.

However...

Looking at the code in index.jsp, i see that some of the details output when the handler is configured as a repeater come from the "master" details ("confFiles" and "replicateAfter") but the entire "master" section isn't returned by the details command when the replication handler is only a master.

so there definitely seems to be a bug -- i'm just not convinced it's what will ment when he filed this jira issue

> replicate/index.jsp UI does not work with repeaters (both master and slave)
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-2314
>                 URL: https://issues.apache.org/jira/browse/SOLR-2314
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.4.1
>         Environment: jdk 1.6.0.23  ; both jetty and jboss/tomcat. 
>            Reporter: will milspec
>            Priority: Minor
>
> Summary:
> ==========
> - Admin UI replication/index.jsp checks for master or slave with the following code:
>    if ("true".equals(detailsMap.get("isSlave"))) 
> -  if slave, replication/index.jsp displays the "Master" and "Poll Intervals", etc. sections (everything up to "Cores")
> - if false, replication/index.jsp does not display the "Master", "Poll Intervals" sections 
> -This "slave check/UI difference" works correctly if the solrconfig.xml has a  "slave" but not "master" section or vice versa
> Expected results:
> ==================
> Same UI difference would occur in the following scenario:
>    a) solrconfig.xml has both master and slave entries
>    b) use java.properties (-Dsolr.enable.master -Dsolr.enable.slave) to set "master" or "slave" at runtime
> *OR*
>     c) use solrcore.properties  to set "master" and "slave" at runtime
> Actual results:
> ==================
> If solrconfig.xml has both master and slave entries, replication/index.jsp shows both "master" and "slave" section regardless of system.properties or solrcore.properties

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org