You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/09/02 23:57:41 UTC
Review Request 38071: RANGER-637 : Make REFERRAL property in Ranger
User sync configurable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38071/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-637
https://issues.apache.org/jira/browse/RANGER-637
Repository: ranger
Description
-------
Currently, REFERRAL property in Ranger usersync (in case of LDAP sync) is hard coded to "follow". Made it configurable by introducing a new property "ranger.usersync.ldap.referral" in the file "ranger-ugsync-template.xml"
Diffs
-----
jisql/src/main/java/org/apache/util/sql/Jisql.java 9c743564a44eaf8f187f084f9e42096b5d82209d
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 93893ef8a614962d5764eb4acfcf7c19424bce0c
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java f8b68f2e6443d83267f2fa258b4e5907f5625780
unixauthservice/scripts/install.properties 521562086c0ee9da4f6d3ba32a7dc9ed74c10294
unixauthservice/scripts/templates/installprop2xml.properties f102b5244d8af301eaf4d048f5480947893ddcef
unixauthservice/scripts/templates/ranger-ugsync-template.xml 268deb3cf0d0aecb2d5086a96fef021f6ca57d30
Diff: https://reviews.apache.org/r/38071/diff/
Testing
-------
Tested on a local centos 6 cluster with LDAP sync
Thanks,
Gautam Borad
Re: Review Request 38071: RANGER-637 : Make REFERRAL property in
Ranger User sync configurable
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38071/#review97544
-----------------------------------------------------------
- Don Bosco Durai
On Sept. 2, 2015, 9:57 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38071/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:57 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-637
> https://issues.apache.org/jira/browse/RANGER-637
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, REFERRAL property in Ranger usersync (in case of LDAP sync) is hard coded to "follow". Made it configurable by introducing a new property "ranger.usersync.ldap.referral" in the file "ranger-ugsync-template.xml"
>
>
> Diffs
> -----
>
> jisql/src/main/java/org/apache/util/sql/Jisql.java 9c743564a44eaf8f187f084f9e42096b5d82209d
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 93893ef8a614962d5764eb4acfcf7c19424bce0c
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java f8b68f2e6443d83267f2fa258b4e5907f5625780
> unixauthservice/scripts/install.properties 521562086c0ee9da4f6d3ba32a7dc9ed74c10294
> unixauthservice/scripts/templates/installprop2xml.properties f102b5244d8af301eaf4d048f5480947893ddcef
> unixauthservice/scripts/templates/ranger-ugsync-template.xml 268deb3cf0d0aecb2d5086a96fef021f6ca57d30
>
> Diff: https://reviews.apache.org/r/38071/diff/
>
>
> Testing
> -------
>
> Tested on a local centos 6 cluster with LDAP sync
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38071: RANGER-637 : Make REFERRAL property in
Ranger User sync configurable
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Sept. 3, 2015, 6 a.m., Madhan Neethiraj wrote:
> > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java, line 721
> > <https://reviews.apache.org/r/38071/diff/1/?file=1062736#file1062736line721>
> >
> > Earlier the used was "follow" - refer LdapUserGroupBuilder.java #147. Now the default is set to "ignore". Is this intentional? It seem keeping the default same as the previous value might be safer.
"Earlier the used was" ==> "Earlier the default used was"
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38071/#review97614
-----------------------------------------------------------
On Sept. 2, 2015, 9:57 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38071/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:57 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-637
> https://issues.apache.org/jira/browse/RANGER-637
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, REFERRAL property in Ranger usersync (in case of LDAP sync) is hard coded to "follow". Made it configurable by introducing a new property "ranger.usersync.ldap.referral" in the file "ranger-ugsync-template.xml"
>
>
> Diffs
> -----
>
> jisql/src/main/java/org/apache/util/sql/Jisql.java 9c743564a44eaf8f187f084f9e42096b5d82209d
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 93893ef8a614962d5764eb4acfcf7c19424bce0c
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java f8b68f2e6443d83267f2fa258b4e5907f5625780
> unixauthservice/scripts/install.properties 521562086c0ee9da4f6d3ba32a7dc9ed74c10294
> unixauthservice/scripts/templates/installprop2xml.properties f102b5244d8af301eaf4d048f5480947893ddcef
> unixauthservice/scripts/templates/ranger-ugsync-template.xml 268deb3cf0d0aecb2d5086a96fef021f6ca57d30
>
> Diff: https://reviews.apache.org/r/38071/diff/
>
>
> Testing
> -------
>
> Tested on a local centos 6 cluster with LDAP sync
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38071: RANGER-637 : Make REFERRAL property in
Ranger User sync configurable
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38071/#review97614
-----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java (line 721)
<https://reviews.apache.org/r/38071/#comment153630>
Earlier the used was "follow" - refer LdapUserGroupBuilder.java #147. Now the default is set to "ignore". Is this intentional? It seem keeping the default same as the previous value might be safer.
unixauthservice/scripts/install.properties (line 173)
<https://reviews.apache.org/r/38071/#comment153631>
Same as the previous comment, about using the default value as "follow" - as in the earlier version.
- Madhan Neethiraj
On Sept. 2, 2015, 9:57 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38071/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:57 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-637
> https://issues.apache.org/jira/browse/RANGER-637
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, REFERRAL property in Ranger usersync (in case of LDAP sync) is hard coded to "follow". Made it configurable by introducing a new property "ranger.usersync.ldap.referral" in the file "ranger-ugsync-template.xml"
>
>
> Diffs
> -----
>
> jisql/src/main/java/org/apache/util/sql/Jisql.java 9c743564a44eaf8f187f084f9e42096b5d82209d
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 93893ef8a614962d5764eb4acfcf7c19424bce0c
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java f8b68f2e6443d83267f2fa258b4e5907f5625780
> unixauthservice/scripts/install.properties 521562086c0ee9da4f6d3ba32a7dc9ed74c10294
> unixauthservice/scripts/templates/installprop2xml.properties f102b5244d8af301eaf4d048f5480947893ddcef
> unixauthservice/scripts/templates/ranger-ugsync-template.xml 268deb3cf0d0aecb2d5086a96fef021f6ca57d30
>
> Diff: https://reviews.apache.org/r/38071/diff/
>
>
> Testing
> -------
>
> Tested on a local centos 6 cluster with LDAP sync
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38071: RANGER-637 : Make REFERRAL property in
Ranger User sync configurable
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38071/#review97545
-----------------------------------------------------------
Ship it!
Ship It!
- Don Bosco Durai
On Sept. 2, 2015, 9:57 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38071/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 9:57 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-637
> https://issues.apache.org/jira/browse/RANGER-637
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, REFERRAL property in Ranger usersync (in case of LDAP sync) is hard coded to "follow". Made it configurable by introducing a new property "ranger.usersync.ldap.referral" in the file "ranger-ugsync-template.xml"
>
>
> Diffs
> -----
>
> jisql/src/main/java/org/apache/util/sql/Jisql.java 9c743564a44eaf8f187f084f9e42096b5d82209d
> ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java 93893ef8a614962d5764eb4acfcf7c19424bce0c
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java f8b68f2e6443d83267f2fa258b4e5907f5625780
> unixauthservice/scripts/install.properties 521562086c0ee9da4f6d3ba32a7dc9ed74c10294
> unixauthservice/scripts/templates/installprop2xml.properties f102b5244d8af301eaf4d048f5480947893ddcef
> unixauthservice/scripts/templates/ranger-ugsync-template.xml 268deb3cf0d0aecb2d5086a96fef021f6ca57d30
>
> Diff: https://reviews.apache.org/r/38071/diff/
>
>
> Testing
> -------
>
> Tested on a local centos 6 cluster with LDAP sync
>
>
> Thanks,
>
> Gautam Borad
>
>