You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/08 19:14:00 UTC
[jira] [Work logged] (GOBBLIN-1355) Make task interruption optional
on Gobblin task cancellation
[ https://issues.apache.org/jira/browse/GOBBLIN-1355?focusedWorklogId=533176&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533176 ]
ASF GitHub Bot logged work on GOBBLIN-1355:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/21 19:13
Start Date: 08/Jan/21 19:13
Worklog Time Spent: 10m
Work Description: sv2000 opened a new pull request #3195:
URL: https://github.com/apache/incubator-gobblin/pull/3195
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1355
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Currently, the thread running a Gobblin task is interrupted when a task cancellation is invoked. When such a task is managing a Kafka consumer for instance, the interrupt leaves the consumer instance in a corrupt state, particularly if the consumer is in the middle of a poll() when the interrupt occurs. This in turn prevents the subsequent clean up of the consumer instance resulting in a potential resource leak.
With this change, we provide the option to avoid interrupting the thread in aforementioned scenarios and let the poll() return before the thread is shutdown.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Trivial change.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 533176)
Remaining Estimate: 0h
Time Spent: 10m
> Make task interruption optional on Gobblin task cancellation
> ------------------------------------------------------------
>
> Key: GOBBLIN-1355
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1355
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the thread running a Gobblin task is interrupted when a task cancellation is invoked. When such a task is managing a Kafka consumer for instance, the interrupt leaves the consumer instance in a corrupt state, particularly if the consumer is in the middle of a poll() when the interrupt occurs. This in turn prevents the subsequent clean up of the consumer instance resulting in a potential resource leak.
> With this change, we provide the option to avoid interrupting the thread in aforementioned scenarios and let the poll() return before the thread is shutdown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)