You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/07 19:12:00 UTC
[jira] [Work logged] (BEAM-6269) Support mixed-language pipelines.
[ https://issues.apache.org/jira/browse/BEAM-6269?focusedWorklogId=496868&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496868 ]
ASF GitHub Bot logged work on BEAM-6269:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/20 19:11
Start Date: 07/Oct/20 19:11
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request #7316:
URL: https://github.com/apache/beam/pull/7316#discussion_r501248667
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java
##########
@@ -629,13 +635,15 @@ private void visit(
if (!isRootNode()) {
// Visit inputs.
for (PValue inputValue : inputs.values()) {
- Node valueProducer = getProducer(inputValue);
- if (!visitedNodes.contains(valueProducer)) {
- valueProducer.visit(visitor, visitedValues, visitedNodes, skippedComposites);
- }
- if (visitedValues.add(inputValue)) {
- LOG.debug("Visiting input value {}", inputValue);
- visitor.visitValue(inputValue, valueProducer);
+ Node valueProducer = maybeGetProducer(inputValue);
+ if (valueProducer != null) {
+ if (!visitedNodes.contains(valueProducer)) {
+ valueProducer.visit(visitor, visitedValues, visitedNodes, skippedComposites);
+ }
+ if (visitedValues.add(inputValue)) {
Review comment:
I was just looking into side inputs. I believe that this change means any value with a direct producer is not visited. So `PCollectionView` is only visited because it is produced by a transform. But in fact if we remove the deprecated `WritePCollectionView` primitive they are never visited. I think they should be visited still. I'm not exactly sure the ramifications. I'll post a PR if I figure it out but LMK if you know already whether this will break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 496868)
Time Spent: 7h 10m (was: 7h)
> Support mixed-language pipelines.
> ---------------------------------
>
> Key: BEAM-6269
> URL: https://issues.apache.org/jira/browse/BEAM-6269
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, runner-core, sdk-java-core, sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Kenneth Knowles
> Priority: P2
> Labels: Done
> Fix For: Not applicable
>
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)