[GitHub] [arrow] westonpace commented on a diff in pull request #35384: GH-35383: [C++] Prefer max_concurrency over executor capacity to avoid segmentation fault

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on code in PR #35384:
URL: https://github.com/apache/arrow/pull/35384#discussion_r1182068507


##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -398,25 +398,25 @@ class ScalarAggregateNode : public ExecNode, public TracedNode {
     auto aggregates = aggregate_options.aggregates;
     const auto& keys = aggregate_options.keys;
     const auto& segment_keys = aggregate_options.segment_keys;
-    const auto concurreny =
-        plan->query_context()->exec_context()->executor()->GetCapacity();
+    const auto concurrency = plan->query_context()->max_concurrency();
+    // We can't use concurrency == 1 because that include I/O concurrency

Review Comment:
   I don't think so.  You'll notice, in the very next line, it is doing the same calculation that max_concurrency does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org