You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2021/08/30 22:53:43 UTC
[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17817
Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback
......................................................................
IMPALA-10885: Deflake test_get_table_req_without_fallback
The test originally was written when events processing
was not turned on by default. However, after
IMPALA-8795 the events processing is turned on by
default and this test fails intermittently.
The error was reproduced by adding a simple
sleep statement in the test just before issuing a
get_table API call which was expected to fail.
Testing:
1. Looped the test for 25 times with the change and with
the sleep statement which reproduced the failure.
Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
---
M tests/custom_cluster/test_metastore_service.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/17817/3
--
To view, visit http://gerrit.cloudera.org:8080/17817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
Gerrit-Change-Number: 17817
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17817 )
Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback
......................................................................
IMPALA-10885: Deflake test_get_table_req_without_fallback
The test originally was written when events processing
was not turned on by default. However, after
IMPALA-8795 the events processing is turned on by
default and this test fails intermittently.
The error was reproduced by adding a simple
sleep statement in the test just before issuing a
get_table API call which was expected to fail.
Testing:
1. Looped the test for 25 times with the change and with
the sleep statement which reproduced the failure.
Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
Reviewed-on: http://gerrit.cloudera.org:8080/17817
Reviewed-by: Vihang Karajgaonkar <vi...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_metastore_service.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Vihang Karajgaonkar: Looks good to me, approved
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
Gerrit-Change-Number: 17817
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17817 )
Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7438/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
Gerrit-Change-Number: 17817
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 22:54:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17817 )
Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback
......................................................................
Patch Set 3: Code-Review+2
self-reviewing this since this is a very simple change.
--
To view, visit http://gerrit.cloudera.org:8080/17817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
Gerrit-Change-Number: 17817
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 23:04:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17817 )
Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9404/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
Gerrit-Change-Number: 17817
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 23:14:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17817 )
Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
Gerrit-Change-Number: 17817
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Aug 2021 04:58:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10885: Deflake test get table req without fallback
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17817 )
Change subject: IMPALA-10885: Deflake test_get_table_req_without_fallback
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I684ec07cc23617d64355df25420c45b0cbedd5a3
Gerrit-Change-Number: 17817
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Aug 2021 23:28:52 +0000
Gerrit-HasComments: No