You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/13 13:30:59 UTC

[GitHub] [nuttx-apps] acassis commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working

acassis commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1069458298


##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
 	bool "Enable commands as parameters"
 	default !DEFAULT_SMALL
 	depends on !DISABLE_MOUNTPOINT
+	select FS_TMPFS
+	select NSH_QUOTE

Review Comment:
   I don't like the idea of using 'depend on' when the dependent features is not enabled by default. It will hide the current feature from user. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org