You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/06 14:16:09 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3948: server:
password is not displayed when reinstall a vm or reset ssh key
ustcweizhou opened a new pull request #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948
## Description
<!--- Describe your changes in detail -->
After reinstall a stopped vm or reset ssh key, the password is reset, and new password is saved in virtual router (if it is running). However we do not get any password in the api response as well as cloudstack UI.
This fixes the issue above.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-596217356
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-596219229
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-597772790
<b>Trillian test result (tid-1228)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28096 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3948-t1228-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 187.83 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 185.43 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 264.79 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-596396789
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-597529775
@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-597526213
Tested LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-596633981
<b>Trillian test result (tid-1215)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27006 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3948-t1215-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 169.91 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 169.67 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 231.84 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-596396386
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3948: server:
password is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-597529314
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3948: server: password is
not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-596217324
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3948: server: password
is not displayed when reinstall a vm or reset ssh key
Posted by GitBox <gi...@apache.org>.
ustcweizhou commented on issue #3948: server: password is not displayed when reinstall a vm or reset ssh key
URL: https://github.com/apache/cloudstack/pull/3948#issuecomment-595787163
@rhtyd this seems to be caused by acc5fdc
could you please review it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services