[GitHub] [activemq-artemis] gemmellr edited a comment on pull request #3812: ARTEMIS-3057 Add min-free-disk-bytes feature

[GitBox <gi...@apache.org>]

gemmellr edited a comment on pull request #3812:
URL: https://github.com/apache/activemq-artemis/pull/3812#issuecomment-950999165


   >I would probably make them mutually exclusive personally, as they will most likely never agree exactly on when to block and unblock so it seems odd to set both. Although that could be awkward since max-disk-usage has a built in default, so its currently 'almost always set' in a way, and your PR currently proposes having a default for the 'min available' too.
   
   
   To handle that I guess I would leave the existing max-disk-usage default to retain existing behaviour, and remove any default for the new 'min available' config. That way you know it was configured explicitly if it is set, and we could choose to document that it takes precedence over the max-disk-usage setting, i.e they can choose to use 'max-disk-usage' or to instead use 'min-disk-...'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org