Re: Review Request 16902: TAJO-497: Rearrange reserved and non-reserved keywords

[Hyunsik Choi <hy...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16902/#review32975
-----------------------------------------------------------

Ship it!


+1

I'm very sorry for the late review. This work may be very tedious, and you may take long time for investigating all non-reserved keywords. I really appreciate you for this work. This work will make Tajo's SQL parser much better.

- Hyunsik Choi


On Jan. 23, 2014, 6:51 p.m., Keuntae Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16902/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 6:51 p.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-497
>     https://issues.apache.org/jira/browse/TAJO-497
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> I've uploaded the patch, which
> - rearranges reserved and non-reserved keywords (some data type tokens are also classified as non-reserved keywords)
>   rearrangement is based on the behavior of PostgreSQL. 
> - moves identifier rule from lexer to parser because it does not work with antlr4 lexer.
> - also adds testVariousTableNames() in TestCreateTable.java.
> 
> 
> Diffs
> -----
> 
>   tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4 2151387 
>   tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 0b7ced0 
>   tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java 5507ba0 
>   tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java f6930ba 
> 
> Diff: https://reviews.apache.org/r/16902/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install passed.
> 
> 
> Thanks,
> 
> Keuntae Park
> 
>