You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by necosta <gi...@git.apache.org> on 2018/01/16 10:58:13 UTC
[GitHub] zeppelin pull request #2731: [ZEPPELIN-3169] Fix maven version set
GitHub user necosta opened a pull request:
https://github.com/apache/zeppelin/pull/2731
[ZEPPELIN-3169] Fix maven version set
### What is this PR for?
Bug fix on changing Maven version (0.8.0-SNAPSHOT -> ?)
### What type of PR is it?
[Bug Fix | Hot Fix ]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3169
### How should this be tested?
* Run 'mvn versions:set -DprocessDependencies=false -DnewVersion=0.8.0-SNAPSHOT-123 -DgenerateBackupPoms=false'
* Run 'mvn clean package -DskipTests'
* Expect BUILD SUCCESS
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin3169
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2731.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2731
----
commit 9f73affb772347751f6924db0ad8a05e2e4bf0a4
Author: Nelson Costa <ne...@...>
Date: 2018-01-16T10:32:35Z
[ZEPPELIN-3169] Fix maven version set
----
---
[GitHub] zeppelin pull request #2731: [ZEPPELIN-3169] Fix maven version set
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2731
---
[GitHub] zeppelin issue #2731: [ZEPPELIN-3169] Fix maven version set
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2731
Thanks @necosta will merge soon
---
[GitHub] zeppelin pull request #2731: [ZEPPELIN-3169] Fix maven version set
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2731
---
[GitHub] zeppelin issue #2731: [ZEPPELIN-3169] Fix maven version set
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2731
Jenkins looks happy. Let me know if you want me to force CI to run again. Thanks
---
[GitHub] zeppelin issue #2731: [ZEPPELIN-3169] Fix maven version set
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2731
LGTM
---
[GitHub] zeppelin pull request #2731: [ZEPPELIN-3169] Fix maven version set
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2731
[ZEPPELIN-3169] Fix maven version set
### What is this PR for?
Bug fix on changing Maven version (0.8.0-SNAPSHOT -> ?)
### What type of PR is it?
[Bug Fix | Hot Fix ]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3169
### How should this be tested?
* Run 'mvn versions:set -DprocessDependencies=false -DnewVersion=0.8.0-SNAPSHOT-123 -DgenerateBackupPoms=false'
* Run 'mvn clean package -DskipTests'
* Expect BUILD SUCCESS
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin zeppelin3169
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2731.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2731
----
----
---
[GitHub] zeppelin issue #2731: [ZEPPELIN-3169] Fix maven version set
Posted by masyan <gi...@git.apache.org>.
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2731
LGTM
---