You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2025/02/12 09:33:50 UTC
[PR] [CELEBORN-1861] Support celeborn.worker.storage.baseDir.diskType option to specify disk type of base directory for worker [celeborn]
SteNicholas opened a new pull request, #3096:
URL: https://github.com/apache/celeborn/pull/3096
### What changes were proposed in this pull request?
Support `celeborn.worker.storage.baseDir.diskType` option to specify disk type of base directory for worker.
### Why are the changes needed?
The disk type of base directory for worker is `HDD` at default. We could support `celeborn.worker.storage.baseDir.diskType` option to specify disk type of base directory for worker.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1861] Support celeborn.worker.storage.baseDir.diskType option to specify disk type of base directory for worker [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3096:
URL: https://github.com/apache/celeborn/pull/3096#issuecomment-2662276803
Ping @FMX, @RexXiong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1861] Support celeborn.worker.storage.baseDir.diskType option to specify disk type of base directory for worker [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #3096: [CELEBORN-1861] Support celeborn.worker.storage.baseDir.diskType option to specify disk type of base directory for worker
URL: https://github.com/apache/celeborn/pull/3096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1861] Support celeborn.worker.storage.baseDir.diskType option to specify disk type of base directory for worker [celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3096:
URL: https://github.com/apache/celeborn/pull/3096#discussion_r1953516408
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3070,6 +3079,18 @@ object CelebornConf extends Logging {
.intConf
.createWithDefault(16)
+ val WORKER_STORAGE_BASE_DIR_DISK_TYPE: ConfigEntry[String] =
+ buildConf("celeborn.worker.storage.baseDir.diskType")
+ .internal
+ .categories("worker")
+ .version("0.6.0")
+ .doc(
+ s"The disk type of base directory for worker. Available options: ${StorageInfo.Type.HDD.name}, ${StorageInfo.Type.SSD.name}.")
Review Comment:
nit: IIUC
```
It only works if ${WORKER_STORAGE_DIRS.key}` is not set.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org