[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2905: Implement ord for FixedSizeBinary types

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2905:
URL: https://github.com/apache/arrow-rs/pull/2905#discussion_r1001069352


##########
arrow/src/array/ord.rs:
##########
@@ -295,6 +295,14 @@ pub fn build_compare(left: &dyn Array, right: &dyn Array) -> Result<DynComparato
             let right: Decimal128Array = Decimal128Array::from(right.data().clone());
             Box::new(move |i, j| left.value(i).cmp(&right.value(j)))
         }
+        (FixedSizeBinary(_), FixedSizeBinary(_)) => {

Review Comment:
   FYI the comparison and sort kernels do not make use of this `DynComparator`, and I actually hope to at some point deprecate it in favor of the row format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org