You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "gharris1727 (via GitHub)" <gi...@apache.org> on 2024/03/04 22:22:12 UTC
[PR] MINOR: Resolve SslContextFactory method deprecations [kafka]
gharris1727 opened a new pull request, #15468:
URL: https://github.com/apache/kafka/pull/15468
The SSLUtilsTest uses the deprecated methods SslContextFactory#getNeedClientAuth and #getWantClientAuth. These are only valid in the context of a server, so they were moved to the SslContextFactory.Server class. We can avoid the deprecation but keep the assertions in the test by using the SslContextFactory.Server type instead of the parent SslContextFactory type.
I did the same for the call-sites in main, and for the SslContextFactory.Client type. This is necessary for a future upgrade of Jetty which actually removes these methods, and expects the specialized forms to be passed-around instead. This should not have any functional changes.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Resolve SslContextFactory method deprecations [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 merged PR #15468:
URL: https://github.com/apache/kafka/pull/15468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Resolve SslContextFactory method deprecations [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #15468:
URL: https://github.com/apache/kafka/pull/15468#issuecomment-1995349571
Test failures appear unrelated, and the connect tests pass for me locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org