You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/04/05 01:14:27 UTC
Review Request: Fixes a bug in the replicated log that doesn't correctly
remove "missing" positions after a truncation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4646/
-----------------------------------------------------------
Review request for mesos, John Sirois and Bill Farner.
Summary
-------
See summary.
Diffs
-----
src/log/replica.cpp 8915c96
Diff: https://reviews.apache.org/r/4646/diff
Testing
-------
make check
Thanks,
Benjamin
Re: Review Request: Fixes a bug in the replicated log that doesn't correctly
remove "missing" positions after a truncation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-04-05 04:17:42, John Sirois wrote:
> >
Thanks guys, getting this committed now (finally).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4646/#review6705
-----------------------------------------------------------
On 2012-04-04 23:14:40, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4646/
> -----------------------------------------------------------
>
> (Updated 2012-04-04 23:14:40)
>
>
> Review request for mesos, John Sirois and Bill Farner.
>
>
> Summary
> -------
>
> See summary.
>
>
> This addresses bug MESOS-178.
> https://issues.apache.org/jira/browse/MESOS-178
>
>
> Diffs
> -----
>
> src/log/replica.cpp 8915c96
>
> Diff: https://reviews.apache.org/r/4646/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Fixes a bug in the replicated log that doesn't correctly
remove "missing" positions after a truncation.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4646/#review6705
-----------------------------------------------------------
Ship it!
- John
On 2012-04-04 23:14:40, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4646/
> -----------------------------------------------------------
>
> (Updated 2012-04-04 23:14:40)
>
>
> Review request for mesos, John Sirois and Bill Farner.
>
>
> Summary
> -------
>
> See summary.
>
>
> This addresses bug MESOS-178.
> https://issues.apache.org/jira/browse/MESOS-178
>
>
> Diffs
> -----
>
> src/log/replica.cpp 8915c96
>
> Diff: https://reviews.apache.org/r/4646/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Fixes a bug in the replicated log that doesn't correctly
remove "missing" positions after a truncation.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4646/#review7206
-----------------------------------------------------------
Ship it!
- John
On 2012-04-04 23:14:40, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4646/
> -----------------------------------------------------------
>
> (Updated 2012-04-04 23:14:40)
>
>
> Review request for mesos, John Sirois and Bill Farner.
>
>
> Summary
> -------
>
> See summary.
>
>
> This addresses bug MESOS-178.
> https://issues.apache.org/jira/browse/MESOS-178
>
>
> Diffs
> -----
>
> src/log/replica.cpp 8915c96
>
> Diff: https://reviews.apache.org/r/4646/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Fixes a bug in the replicated log that doesn't correctly
remove "missing" positions after a truncation.
Posted by Bill Farner <bi...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4646/#review6701
-----------------------------------------------------------
Ship it!
- Bill
On 2012-04-04 23:14:40, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4646/
> -----------------------------------------------------------
>
> (Updated 2012-04-04 23:14:40)
>
>
> Review request for mesos, John Sirois and Bill Farner.
>
>
> Summary
> -------
>
> See summary.
>
>
> This addresses bug MESOS-178.
> https://issues.apache.org/jira/browse/MESOS-178
>
>
> Diffs
> -----
>
> src/log/replica.cpp 8915c96
>
> Diff: https://reviews.apache.org/r/4646/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Fixes a bug in the replicated log that doesn't correctly
remove "missing" positions after a truncation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4646/
-----------------------------------------------------------
(Updated 2012-04-04 23:14:40.355271)
Review request for mesos, John Sirois and Bill Farner.
Changes
-------
Added bug.
Summary
-------
See summary.
This addresses bug MESOS-178.
https://issues.apache.org/jira/browse/MESOS-178
Diffs
-----
src/log/replica.cpp 8915c96
Diff: https://reviews.apache.org/r/4646/diff
Testing
-------
make check
Thanks,
Benjamin