You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/02 13:08:56 UTC
[GitHub] [kafka] dejan2609 opened a new pull request #10626: KAFKA-12744: Breaking change dependency upgrade: "argparse4j" 0.7.0 -->> 0.9.0
dejan2609 opened a new pull request #10626:
URL: https://github.com/apache/kafka/pull/10626
Corresponding JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-12744
Migration guide: https://argparse4j.github.io/migration.html#to-0-8-0
Release notes:
* https://github.com/argparse4j/argparse4j/releases/tag/argparse4j-0.8.0
* https://github.com/argparse4j/argparse4j/releases/tag/argparse4j-0.8.1
* https://github.com/argparse4j/argparse4j/releases/tag/argparse4j-0.9.0
Related to this PR: #10094 and this commit: https://github.com/apache/kafka/commit/690f72dd69d31589655c84d3cc1a6eec006bcab5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 commented on pull request #10626: KAFKA-12744: Breaking change dependency upgrade: "argparse4j" 0.7.0 -->> 0.9.0
Posted by GitBox <gi...@apache.org>.
dejan2609 commented on pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#issuecomment-835492000
Update / mental note: basically I will have to create a binary out of this PR, start Zookeeper, run Kafka Broker and so on: https://dzone.com/articles/apache-kafka-basic-setup-and-usage-with-command-li
After that I will test as much as possible:
- https://gist.github.com/ursuad/e5b8542024a15e4db601f34906b30bb5
- https://www.tutorialspoint.com/apache_kafka/apache_kafka_basic_operations.htm
- https://kontext.tech/column/streaming-analytics/476/kafka-windows-cli-commands
- https://medium.com/@TimvanBaarsen/apache-kafka-cli-commands-cheat-sheet-a6f06eac01b
- https://docs.cloudera.com/documentation/enterprise/6/6.3/topics/kafka_admin_cli.html
- https://myknowpega.com/2020/06/30/kafka-2-set-up-and-cli-tutorial/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 commented on a change in pull request #10626: KAFKA-12744: Breaking change dependency upgrade: "argparse4j" 0.7.0 -->> 0.9.0
Posted by GitBox <gi...@apache.org>.
dejan2609 commented on a change in pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#discussion_r624694456
##########
File path: shell/src/main/java/org/apache/kafka/shell/ManCommandHandler.java
##########
@@ -87,7 +87,7 @@ public void run(Optional<InteractiveShell> shell,
writer.println("man: unknown command " + cmd +
". Type help to get a list of commands.");
} else {
- ArgumentParser parser = ArgumentParsers.newArgumentParser(type.name(), false);
+ ArgumentParser parser = ArgumentParsers.newFor(type.name()).build();
Review comment:
This also needs a review.
##########
File path: shell/src/main/java/org/apache/kafka/shell/Commands.java
##########
@@ -95,7 +95,7 @@ void completeNext(MetadataNodeManager nodeManager,
* @param addShellCommands True if we should include the shell-only commands.
*/
public Commands(boolean addShellCommands) {
- this.parser = ArgumentParsers.newArgumentParser("", false);
+ this.parser = ArgumentParsers.newFor("shell-commands").build();
Review comment:
Note: I think need a review for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 commented on pull request #10626: KAFKA-12744: Breaking change dependency upgrade: "argparse4j" 0.7.0 -->> 0.9.0
Posted by GitBox <gi...@apache.org>.
dejan2609 commented on pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#issuecomment-830835598
@ijuma To be honest: no, I did not test commands directly (thing is that **_Kafka CLI tools_** are a new concept for me).
Just to be sure: I presume you are referring to these CLI tools:
- https://docs.confluent.io/platform/current/tutorials/examples/clients/docs/kafka-commands.html
- https://docs.cloudera.com/documentation/kafka/latest/topics/kafka_command_line.html
- https://docs.cloudera.com/runtime/7.2.9/kafka-managing/topics/kafka-manage-cli-overview.html
Feel free to drop me some related resource / example / github repository (if you know one) so I can test/run commands on my end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dejan2609 commented on pull request #10626: KAFKA-12744: Breaking change dependency upgrade: "argparse4j" 0.7.0 -->> 0.9.0
Posted by GitBox <gi...@apache.org>.
dejan2609 commented on pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#issuecomment-838902447
Changing status to draft (until test CLI, as mentioned in a comments above),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10626: KAFKA-12744: Breaking change dependency upgrade: "argparse4j" 0.7.0 -->> 0.9.0
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#issuecomment-830813257
Thanks for the PR. Given that testing for CLI tools is usually not as good as it should be, have you tried running the commands yourself after these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org