[GitHub] [hadoop] hdaikoku commented on a diff in pull request #5818: HADOOP-18793: S3A StagingCommitter does not clean up staging-uploads directory

["hdaikoku (via GitHub)" <gi...@apache.org>]

hdaikoku commented on code in PR #5818:
URL: https://github.com/apache/hadoop/pull/5818#discussion_r1256030064


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/staging/StagingCommitter.java:
##########
@@ -556,14 +574,6 @@ protected void abortJobInternal(CommitContext commitContext,
    * @throws IOException IO failure
    */
   protected void deleteDestinationPaths(JobContext context) throws IOException {
-    Path attemptPath = getJobAttemptPath(context);
-    ignoreIOExceptions(LOG,
-        "Deleting Job attempt Path", attemptPath.toString(),
-        () -> deleteWithWarning(
-            getJobAttemptFileSystem(context),
-            attemptPath,
-            true));

Review Comment:
   Removed these as `attemptPath` here is a sub dir under `${UUID}/staging-uploads`, which has already been deleted in  `deleteStagingUploadsParentDirectory()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org