[GitHub] [calcite] jinxing64 removed a comment on issue #1434: [CALCITE-2970] Performance issue when enabling merge join.

[GitBox <gi...@apache.org>]

jinxing64 removed a comment on issue #1434: [CALCITE-2970] Performance issue when enabling merge join. 
URL: https://github.com/apache/calcite/pull/1434#issuecomment-527059182
 
 
   Weird, it's complaining
   ```
   [ERROR] testMergeJoin(org.apache.calcite.plan.volcano.VolcanoPlannerTest)  Time elapsed: 0.167 s  <<< FAILURE!
   java.lang.AssertionError: 
   Merge join + sort is expected
   Expected: is "EnumerableMergeJoin(condition=[=($0, $2)], joinType=[inner])\r\n  EnumerableSort(sort0=[$0], dir0=[ASC])\r\n    EnumerableValues(tuples=[[{ '2', 'a' }, { '1', 'b' }]])\r\n  EnumerableValues(tuples=[[{ '1', 'x' }, { '2', 'y' }]])\r\n"
       but: was "EnumerableMergeJoin(condition=[=($0, $2)], joinType=[inner])\n  EnumerableSort(sort0=[$0], dir0=[ASC])\n    EnumerableValues(tuples=[[{ '2', 'a' }, { '1', 'b' }]])\n  EnumerableValues(tuples=[[{ '1', 'x' }, { '2', 'y' }]])\n"
   	at org.apache.calcite.plan.volcano.VolcanoPlannerTest.testMergeJoin(VolcanoPlannerTest.java:449)
   ```
   Seems the expected and actual are the same except '\r\n' and '\n'. But succeeded in my local.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services