You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/29 13:47:14 UTC
[PR] Add E2E coverage for PostgreSQL and openGauss composite type OID [shardingsphere]
terrymanu opened a new pull request, #39272:
URL: https://github.com/apache/shardingsphere/pull/39272
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add E2E coverage for PostgreSQL and openGauss composite type OID [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39272:
URL: https://github.com/apache/shardingsphere/pull/39272#issuecomment-5118914175
### Result
**Review Result: Mergeable**
The PR adds valid PostgreSQL/openGauss composite-type OID regression coverage without changing production behavior. No correctness blockers were found.
### Evidence
- Reviewed public head `ec5663493b89f75a92375ca7fd40347cda749a84`; GitHub and local triple-dot scopes match at 2/2 files.
- `BaseDQLE2EIT.java:178-180` now compares both JDBC type and database-specific type name for `Types.STRUCT`.
- `e2e-dql-select-for-passthrough.xml:78-80` selects a table alias as a composite value through Proxy and compares its metadata with a direct PostgreSQL/openGauss connection.
- The harness exercises both `Statement` and `PreparedStatement` paths through `GeneralDQLE2EIT.java:105-142`.
- This semantically covers the production fixes in [#39241](https://github.com/apache/shardingsphere/pull/39241) and [#39253](https://github.com/apache/shardingsphere/pull/39253): an incorrect OID changes the client-visible structured type or type name.
- PostgreSQL documents table aliases as composite row values, and pgJDBC 42.7.8 maps composite catalog types to `Types.STRUCT`: [PostgreSQL composite types](https://www.postgresql.org/docs/17/rowtypes.html), [pgJDBC TypeInfoCache](https://github.com/pgjdbc/pgjdbc/blob/REL42.7.8/pgjdbc/src/main/java/org/postgresql/jdbc/TypeInfoCache.java#L270-L282).
- openGauss 3.1.0 documentation defines composite JDBC values using `Types.STRUCT`; the repository’s 3.1.0-og driver artifact was also verified to expose the same metadata mapping: [openGauss JDBC documentation](https://docs.opengauss.org/en/docs/3.1.0/docs/Developerguide/running-sql-statements.html).
- `./mvnw -pl test/e2e/sql -DskipTests -Dspotless.skip=true test-compile` — exit 0, `BUILD SUCCESS`.
- `xmllint --noout …/e2e-dql-select-for-passthrough.xml` — exit 0.
### Coverage
- Head: `ec5663493b89f75a92375ca7fd40347cda749a84`
- Merge-base: `091ae171a7df6bb0638eb12d9ea9c0594eec9997`
- Files accounted for: 2/2
- Behavior clusters: composite metadata E2E coverage; stale private checked-exception cleanup
- Discovery lenses completed: root cause and behavior; blast radius and contracts; tests, runtime, and operations
- Unresolved blocker-changing gaps: none
- Docker-backed E2E execution was not started under read-only review authority.
- Code-scope result only; CI and GitHub Actions status were not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add E2E coverage for PostgreSQL and openGauss composite type OID [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39272:
URL: https://github.com/apache/shardingsphere/pull/39272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org