You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/21 16:02:03 UTC
[GitHub] [spark] sarutak opened a new pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
sarutak opened a new pull request #31283:
URL: https://github.com/apache/spark/pull/31283
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR fixes the issue that reading tables which contain spatial datatypes from MS SQL Server fails.
MS SQL server supports two non-standard spatial JDBC types, `geometry` and `geography` but Spark SQL can't treat them
```
java.sql.SQLException: Unrecognized SQL type -157
at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.getCatalystType(JdbcUtils.scala:251)
at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.$anonfun$getSchema$1(JdbcUtils.scala:321)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils$.getSchema(JdbcUtils.scala:321)
at org.apache.spark.sql.execution.datasources.jdbc.JDBCRDD$.resolveTable(JDBCRDD.scala:63)
at org.apache.spark.sql.execution.datasources.jdbc.JDBCRelation$.getSchema(JDBCRelation.scala:226)
at org.apache.spark.sql.execution.datasources.jdbc.JdbcRelationProvider.createRelation(JdbcRelationProvider.scala:35)
at org.apache.spark.sql.execution.datasources.DataSource.resolveRelation(DataSource.scala:364)
at org.apache.spark.sql.DataFrameReader.loadV1Source(DataFrameReader.scala:366)
at org.apache.spark.sql.DataFrameReader.$anonfun$load$2(DataFrameReader.scala:355)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.spark.sql.DataFrameReader.load(DataFrameReader.scala:355)
at org.apache.spark.sql.DataFrameReader.load(DataFrameReader.scala:240)
at org.apache.spark.sql.DataFrameReader.jdbc(DataFrameReader.scala:381)
```
Considering the [data type mapping](https://docs.microsoft.com/ja-jp/sql/connect/jdbc/using-basic-data-types?view=sql-server-ver15) says, I think those spatial types can be mapped to Catalyst's `BinaryType`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To provide better support.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. MS SQL Server users can use `geometry` and `geography` types in datasource tables.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New test case added to `MsSqlServerIntegrationSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764752437
**[Test build #134339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134339/testReport)** for PR 31283 at commit [`8575958`](https://github.com/apache/spark/commit/85759584211186a8bedf2cd6598930094e1db380).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764870584
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134339/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764854189
**[Test build #134339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134339/testReport)** for PR 31283 at commit [`8575958`](https://github.com/apache/spark/commit/85759584211186a8bedf2cd6598930094e1db380).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764836341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764870584
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134339/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764752437
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-765113378
@sarutak can you help to open backport PRs for 3.1/3.0? thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-765113008
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764797077
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38926/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764836341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764836341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38926/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-765113008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764831088
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38926/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764746776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764746776
cc: @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764836341
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38926/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31283:
URL: https://github.com/apache/spark/pull/31283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764752437
**[Test build #134339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134339/testReport)** for PR 31283 at commit [`8575958`](https://github.com/apache/spark/commit/85759584211186a8bedf2cd6598930094e1db380).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-764752437
**[Test build #134339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134339/testReport)** for PR 31283 at commit [`8575958`](https://github.com/apache/spark/commit/85759584211186a8bedf2cd6598930094e1db380).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31283:
URL: https://github.com/apache/spark/pull/31283#issuecomment-765113682
@cloud-fan Sure. I'll open them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31283: [SPARK-33813][SQL] Fix the issue that JDBC source can't treat MS SQL Server's spatial types
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31283:
URL: https://github.com/apache/spark/pull/31283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org