You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/08/13 02:23:41 UTC

[GitHub] spark pull request #21369: [SPARK-22713][CORE] ExternalAppendOnlyMap leaks w...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21369#discussion_r209480155
  
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala ---
    @@ -114,7 +117,10 @@ class ExternalAppendOnlyMap[K, V, C](
       private val keyComparator = new HashComparator[K]
       private val ser = serializer.newInstance()
     
    -  @volatile private var readingIterator: SpillableIterator = null
    +  /**
    +   * Exposed for testing
    +   */
    +  @volatile private[collection] var readingIterator: SpillableIterator = null
    --- End diff --
    
    This is not exposed in the test.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org