You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by jg...@apache.org on 2018/11/26 14:50:41 UTC

[2/6] tomee git commit: removes String concatenation loop in AnnotationDeployer

removes String concatenation loop in AnnotationDeployer


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/afec54d2
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/afec54d2
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/afec54d2

Branch: refs/heads/master
Commit: afec54d2204e6e5b8814cddc7eef427a35b54dd5
Parents: 442a81b
Author: Otavio Santana <ot...@gmail.com>
Authored: Thu Nov 22 13:24:04 2018 -0200
Committer: Otavio Santana <ot...@gmail.com>
Committed: Thu Nov 22 13:24:04 2018 -0200

----------------------------------------------------------------------
 .../java/org/apache/openejb/config/AnnotationDeployer.java   | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tomee/blob/afec54d2/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java b/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
index 9df12fe..98b5484 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
@@ -2939,12 +2939,14 @@ public class AnnotationDeployer implements DynamicDeployer {
                         }
 
                         if (interfaces.size() != 1) {
-                            String msg = "When annotating a bean class as @MessageDriven without declaring messageListenerInterface, the bean must implement exactly one interface, no more and no less. beanClass=" + clazz.getName() + " interfaces=";
+                            StringBuilder msg = new StringBuilder("When annotating a bean class as @MessageDriven without" +
+                                    " declaring messageListenerInterface, the bean must implement exactly one interface, no more and" +
+                                    " no less. beanClass=" + clazz.getName() + " interfaces=");
                             for (final Class<?> intf : interfaces) {
-                                msg += intf.getName() + ", ";
+                                msg.append(intf.getName()).append(", ");
                             }
                             // TODO: Make this a validation failure, not an exception
-                            throw new IllegalStateException(msg);
+                            throw new IllegalStateException(msg.toString());
                         }
                         mdb.setMessagingType(interfaces.get(0).getName());
                     }