[GitHub] avro pull request #248: AVRO-2079: Add ability to generate Java8 native date...

[aukevanleeuwen <gi...@git.apache.org>]

GitHub user aukevanleeuwen opened a pull request:

    https://github.com/apache/avro/pull/248

    AVRO-2079: Add ability to generate Java8 native date/time classes

    Some remarks:
    * I've added the type (either Joda or Java8) to the constructor of the `SpecificCompiler`. This mainly because it affects the state of the compiler (i.e. it would add/remove converters based on this attribute) and I would rather not do this in a setter. 
    * I have renamed the original class `TimeConversions` to `JodaTimeConversions` for clarity, but it clutters the changeset a bit. I can revert that If needed.
    * I've generated `lang/java/avro/src/test/java/org/apache/avro/specific/TestRecordWithJava8LogicalTypes.java` with the new compiler switch `-dateTimeLogicalType java8` and created tests for compatibility witgh the already existing generated classes based on the Joda time.
    * I'm defaulting to Joda time for compatibility reasons. In both Maven and the command line generation tool you have the ability to override that default.
    
    Let me know if there's something I'm missing or am overlooking functionally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aukevanleeuwen/avro use-java8-time

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #248
    
----
commit 78aae1395cc17e47d73f7595611622535ccc90d3
Author: Auke van Leeuwen <av...@schubergphilis.com>
Date:   2017-09-21T08:01:48Z

    AVRO-2079: Add ability to generate Java8 native date/time classes

----


---