You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 20:30:31 UTC
[GitHub] [superset] codecov-io edited a comment on pull request #12465: fix(native-filters): Setting default value
codecov-io edited a comment on pull request #12465:
URL: https://github.com/apache/superset/pull/12465#issuecomment-758929340
# [Codecov](https://codecov.io/gh/apache/superset/pull/12465?src=pr&el=h1) Report
> Merging [#12465](https://codecov.io/gh/apache/superset/pull/12465?src=pr&el=desc) (fc469dd) into [master](https://codecov.io/gh/apache/superset/commit/0f731f27e4b41ca63689094ad57c94cc5aa75b89?el=desc) (0f731f2) will **decrease** coverage by `14.99%`.
> The diff coverage is `55.88%`.
[](https://codecov.io/gh/apache/superset/pull/12465?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12465 +/- ##
===========================================
- Coverage 65.97% 50.97% -15.00%
===========================================
Files 1015 475 -540
Lines 49548 16921 -32627
Branches 5080 4358 -722
===========================================
- Hits 32687 8625 -24062
+ Misses 16714 8296 -8418
+ Partials 147 0 -147
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.97% <55.88%> (+5.40%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12465?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `46.15% <0.00%> (-14.72%)` | :arrow_down: |
| [...rd/components/nativeFilters/DefaultValueSelect.tsx](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRGVmYXVsdFZhbHVlU2VsZWN0LnRzeA==) | `60.00% <60.00%> (ø)` | |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `50.38% <71.42%> (-3.14%)` | :arrow_down: |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `64.10% <100.00%> (-18.05%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `37.50% <100.00%> (-23.37%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| ... and [891 more](https://codecov.io/gh/apache/superset/pull/12465/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12465?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12465?src=pr&el=footer). Last update [0f731f2...fc469dd](https://codecov.io/gh/apache/superset/pull/12465?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org