You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2025/12/07 15:01:23 UTC
(hbase) branch master updated: HBASE-28158 Addendum use equals instead of == (#7526)
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/master by this push:
new a2a35aaa68e HBASE-28158 Addendum use equals instead of == (#7526)
a2a35aaa68e is described below
commit a2a35aaa68eadc738cfc7c1db5a1f0139e0e69df
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Sun Dec 7 23:01:17 2025 +0800
HBASE-28158 Addendum use equals instead of == (#7526)
Co-authored-by: Kevin Geiszler <kg...@cloudera.com>
Signed-off-by: Nihal Jain <ni...@apache.org>
Signed-off-by: Chandra Sekhar K <ch...@apache.org>
---
.../apache/hadoop/hbase/master/assignment/AssignmentManager.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
index aa794f4bf67..967188faba3 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
@@ -2334,11 +2334,15 @@ public class AssignmentManager {
public void markRegionsAsCrashed(List<RegionInfo> regionsOnCrashedServer,
ServerCrashProcedure scp) {
ServerName crashedServerName = scp.getServerName();
+ assert crashedServerName != null;
for (RegionInfo regionInfo : regionsOnCrashedServer) {
RegionStateNode node = regionStates.getOrCreateRegionStateNode(regionInfo);
- if (node.getRegionLocation() == crashedServerName) {
+ if (crashedServerName.equals(node.getRegionLocation())) {
node.crashed(scp.getSubmittedTime());
regionInTransitionTracker.regionCrashed(node);
+ } else {
+ LOG.warn("Region {} should be on crashed region server {} but is recorded on {}", regionInfo,
+ crashedServerName, node.getRegionLocation());
}
}
}