You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/14 14:45:22 UTC
[GitHub] [hudi] geertjanw opened a new pull request #3659: Use fixed JDK version for CI, with applicable OpenJDK distro
geertjanw opened a new pull request #3659:
URL: https://github.com/apache/hudi/pull/3659
## What is the purpose of the pull request
This pull request enables Apache Hudi to do GitHub Actions actions/setup-java against the latest JDK 8 version (as was the case before this pull request) as well as a fixed JDK 8 version. This is useful because if you do a build and the fixed JDK 8 version is green (it succeeded), while the latest JDK 8 version is red (it failed), that gives you information about the reason for the build failure: it was because of something to do with the latest JDK 8 and not something connected directly to your code.
You were using 'adopt', which is no more, 'temurin' and 'zulu' are the two officially supported options, 'temurin' is new and doesn't yet have all/as many versions as 'zulu' does, which is older and therefore has a longer history applicable to this. Hence changed from 'adopt' to 'zulu'.
## Brief change log
This change added tests and can be verified as follows:
- *Make a change anywhere and commit or provide a pull request.*
- *The actions/setup-java will do two builds, i.e., against two different JDK 8 versions.*
- *Both will/should go green..*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #3659: Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#discussion_r708408468
##########
File path: .github/workflows/bot.yml
##########
@@ -15,6 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
+ java: [8, 8.0.192]
Review comment:
think it should go to the `include:` list below along with "scala" and "spark"? just `'8'`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3659: Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#issuecomment-919226362
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9faeecc79ebc0226d0e3a4140147f10a678532f2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9faeecc79ebc0226d0e3a4140147f10a678532f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9faeecc79ebc0226d0e3a4140147f10a678532f2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] geertjanw commented on pull request #3659: [MINOR] Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#issuecomment-919927899
Ah, I see. Apologies for not doing it correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #3659: [MINOR] Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#issuecomment-921206253
@geertjanw no worries. mind fixing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3659: Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#issuecomment-919226362
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9faeecc79ebc0226d0e3a4140147f10a678532f2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2208",
"triggerID" : "9faeecc79ebc0226d0e3a4140147f10a678532f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9faeecc79ebc0226d0e3a4140147f10a678532f2 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2208)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] geertjanw commented on pull request #3659: [MINOR] Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#issuecomment-922103526
For sure, will provide a new pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3659: Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#issuecomment-919226362
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9faeecc79ebc0226d0e3a4140147f10a678532f2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2208",
"triggerID" : "9faeecc79ebc0226d0e3a4140147f10a678532f2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9faeecc79ebc0226d0e3a4140147f10a678532f2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2208)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] geertjanw closed pull request #3659: [MINOR] Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
geertjanw closed pull request #3659:
URL: https://github.com/apache/hudi/pull/3659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] geertjanw commented on pull request #3659: [MINOR] Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#issuecomment-923897472
Closing this one and will provide a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #3659: Use fixed JDK version for CI, with applicable OpenJDK distro
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3659:
URL: https://github.com/apache/hudi/pull/3659#discussion_r708403892
##########
File path: .github/workflows/bot.yml
##########
@@ -15,6 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
+ java: [8, 8.0.192]
Review comment:
do we still need this? would just `java: '8'` work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org