[GitHub] [druid] gianm edited a comment on pull request #11848: Add support for multi dimension range partitioning

[GitBox <gi...@apache.org>]

gianm edited a comment on pull request #11848:
URL: https://github.com/apache/druid/pull/11848#issuecomment-960471721


   The overall design / API looks good based on the PR description (I haven't looked at the code). It'll be a great feature.
   
   I wanted to ask about compatibility during rolling updates and rollbacks:
   
   1. If someone updates to the new version, but doesn't use the new feature (i.e. they keep submitting ingest specs with `single_dim` shard specs), will that lead to segments getting written with `single_dim` or `multi_dim` shard specs? Hopefully it's `single_dim`, since that means people can safely roll back without losing the ability to load their existing segments.
   2. If someone is in the middle of a rolling update to the new version, and has some servers updated but not others, will that be safe? Or will some servers write out `multi_dim` shard specs or other `multi_dim` things that other servers on the older version cannot read?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org