You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zihaoAK47 (via GitHub)" <gi...@apache.org> on 2023/11/12 12:47:26 UTC
[PR] Add oracle select union statement parse test [shardingsphere]
zihaoAK47 opened a new pull request, #29015:
URL: https://github.com/apache/shardingsphere/pull/29015
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
- Add complex select union query statement parsing test
- Add multiple union statement parsing test
- Add multiple union priority test
- Priority Description Reference [link](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/The-UNION-ALL-INTERSECT-MINUS-Operators.html#GUID-B64FE747-586E-4513-945F-80CB197125EE)
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ✓] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ✓] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ✓] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ✓] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add oracle select union statement parse test [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #29015:
URL: https://github.com/apache/shardingsphere/pull/29015#issuecomment-1807296367
Hi @zihaoAK47, can you show antlr preview for more than one union statement? It seems that the priority processing of multiple Union statements is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add oracle select union statement parse test [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #29015:
URL: https://github.com/apache/shardingsphere/pull/29015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add oracle select union statement parse test [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #29015:
URL: https://github.com/apache/shardingsphere/pull/29015#issuecomment-1810012358
> > Hi @zihaoAK47, can you show antlr preview for more than one union statement? It seems that the priority processing of multiple Union statements is wrong.
>
> Hi mentor, I have submitted a new parsing code. The following is a preview image of Antlr parsing
>
>  
Now the result of sql parser is correct, thank you for correct it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add oracle select union statement parse test [shardingsphere]
Posted by "zihaoAK47 (via GitHub)" <gi...@apache.org>.
zihaoAK47 commented on PR #29015:
URL: https://github.com/apache/shardingsphere/pull/29015#issuecomment-1810005603
> Hi @zihaoAK47, can you show antlr preview for more than one union statement? It seems that the priority processing of multiple Union statements is wrong.
Hi mentor, I have submitted a new parsing code.
The following is a preview image of Antlr parsing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org